Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

feat(rome_js_ananlyze): noImportAssign #2922

Merged
merged 12 commits into from
Aug 3, 2022
Merged

feat(rome_js_ananlyze): noImportAssign #2922

merged 12 commits into from
Aug 3, 2022

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Jul 24, 2022 •
edited
Loading

Summary

  1. Resolved 📎 noImportAssign #2923

Test Plan

  1. cargo test

@IWANABETHATGUY IWANABETHATGUY requested a review from a team July 24, 2022 11:43
@IWANABETHATGUY IWANABETHATGUY requested a review from ematipico July 25, 2022 14:57
@IWANABETHATGUY
Copy link
Contributor Author

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      3.5±0.15ms     3.4 MB/sec    1.12      3.9±0.16ms     3.0 MB/sec
analyzer/index.js         1.00      7.6±0.27ms     4.2 MB/sec    1.01      7.7±0.23ms     4.2 MB/sec
analyzer/lint.ts          1.00      4.8±0.16ms     8.7 MB/sec    1.00      4.8±0.18ms     8.6 MB/sec
analyzer/parser.ts        1.00     11.1±0.30ms     4.4 MB/sec    1.10     12.2±0.42ms     4.0 MB/sec
analyzer/router.ts        1.00      7.5±0.25ms     8.1 MB/sec    1.07      8.0±0.25ms     7.6 MB/sec
analyzer/statement.ts     1.02     10.1±0.36ms     3.5 MB/sec    1.00      9.9±0.30ms     3.6 MB/sec
analyzer/typescript.ts    1.01     14.8±0.52ms     3.7 MB/sec    1.00     14.7±0.41ms     3.7 MB/sec

@IWANABETHATGUY
Copy link
Contributor Author

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.7±0.04ms     4.3 MB/sec    1.11      3.0±0.02ms     3.9 MB/sec
analyzer/index.js         1.00      5.9±0.03ms     5.4 MB/sec    1.01      6.0±0.01ms     5.4 MB/sec
analyzer/lint.ts          1.00      3.7±0.01ms    11.2 MB/sec    1.00      3.7±0.02ms    11.2 MB/sec
analyzer/parser.ts        1.00      8.6±0.06ms     5.6 MB/sec    1.10      9.4±0.01ms     5.1 MB/sec
analyzer/router.ts        1.00      5.9±0.01ms    10.4 MB/sec    1.08      6.3±0.14ms     9.7 MB/sec
analyzer/statement.ts     1.00      7.7±0.05ms     4.6 MB/sec    1.00      7.7±0.01ms     4.6 MB/sec
analyzer/typescript.ts    1.00     11.3±0.02ms     4.8 MB/sec    1.00     11.3±0.04ms     4.8 MB/sec

@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/no-import-assign branch from 6ba8656 to d0c232f Compare July 25, 2022 15:39
@IWANABETHATGUY
Copy link
Contributor Author

IWANABETHATGUY commented Jul 25, 2022 •
edited
Loading

@xunilrj , would you mind helping with reviewing? I can't find any way to optimize this implementation

@IWANABETHATGUY
Copy link
Contributor Author

!bench_analyzer

@github-actions
Copy link

Analyzer Benchmark Results

group                     main                                   pr
-----                     ----                                   --
analyzer/css.js           1.00      2.3±0.02ms     5.2 MB/sec    1.01      2.3±0.02ms     5.1 MB/sec
analyzer/index.js         1.00      5.4±0.03ms     6.0 MB/sec    1.00      5.4±0.05ms     5.9 MB/sec
analyzer/lint.ts          1.00      3.2±0.02ms    13.1 MB/sec    1.01      3.2±0.03ms    12.9 MB/sec
analyzer/parser.ts        1.00      7.3±0.04ms     6.6 MB/sec    1.01      7.4±0.04ms     6.5 MB/sec
analyzer/router.ts        1.00      5.1±0.02ms    12.0 MB/sec    1.00      5.1±0.04ms    12.0 MB/sec
analyzer/statement.ts     1.00      7.0±0.03ms     5.1 MB/sec    1.01      7.0±0.06ms     5.1 MB/sec
analyzer/typescript.ts    1.00     10.2±0.07ms     5.3 MB/sec    1.00     10.2±0.08ms     5.3 MB/sec

@IWANABETHATGUY
Copy link
Contributor Author

The performance looks good now.

@IWANABETHATGUY IWANABETHATGUY requested a review from xunilrj July 30, 2022 12:58
@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/no-import-assign branch from d4a9720 to b3a83df Compare July 30, 2022 13:16
@ematipico
Copy link
Contributor

Let's hold the merging of this PR until this PR #2980 lands

@IWANABETHATGUY IWANABETHATGUY force-pushed the feat/no-import-assign branch from 3ae91e1 to b1628e5 Compare August 3, 2022 08:01
@IWANABETHATGUY
Copy link
Contributor Author

Since #2980 has landed, I thinks this pull request is good to merge now.

@leops leops merged commit 9053dfb into rome:main Aug 3, 2022
@IWANABETHATGUY IWANABETHATGUY deleted the feat/no-import-assign branch August 3, 2022 09:49
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Aug 3, 2022
Merged
IWANABETHATGUY added a commit to IWANABETHATGUY/tools that referenced this pull request Aug 22, 2022
@IWANABETHATGUY
feat(rome_js_ananlyze): noImportAssign (rome#2922)
39e31a2 
* feat: 🎸 no-import-assign

* style: 💄 fmt

* fix: 🐛 cr issues

* docs: ✏️ update doc

* chore: 🤖 avoid unncessary cast

* chore: 🤖 lintdoc

* fix: 🐛 use ctx model api

* fix: 🐛 lint doc

* fix: 🐛 cr issue

* fix: 🐛 cr issue

* chore: 🤖 update log

* chore: 🤖 codegen configuration
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ematipico ematipico ematipico approved these changes

@xunilrj xunilrj xunilrj approved these changes

@leops leops Awaiting requested review from leops

@MichaReiser MichaReiser Awaiting requested review from MichaReiser

Assignees

@xunilrj xunilrj

@IWANABETHATGUY IWANABETHATGUY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

📎 noImportAssign
4 participants
@IWANABETHATGUY @ematipico @xunilrj @leops