Skip to content
This repository was archived by the owner on Aug 31, 2023. It is now read-only.

Commit 3ae91e1

Browse files
chore: 🤖 update log
1 parent b3a83df commit 3ae91e1

File tree

3 files changed

+15
-30
lines changed

3 files changed

+15
-30
lines changed

crates/rome_js_analyze/src/semantic_analyzers/js/no_import_assign.rs

+2-3
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ declare_rule! {
2626
/// ```
2727
/// ```js,expect_diagnostic
2828
/// import z from "y";
29-
/// ({ z } = 1);
30-
/// ```
29+
/// ({ z } = 1); /// ```
3130
/// ```js,expect_diagnostic
3231
/// import a from "y";
3332
/// [...a] = 1;
@@ -50,7 +49,7 @@ declare_rule! {
5049
/// e = 1;
5150
/// ```
5251
pub(crate) NoImportAssign {
53-
version: "0.8.0",
52+
version: "0.9.0",
5453
name: "noImportAssign",
5554
recommended: true,
5655
}

website/src/docs/lint/rules/index.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ Disallow reassigning function declarations.
9494
</div>
9595
<div class="rule">
9696
<h3 data-toc-exclude id="noImportAssign">
97-
<a href="/docs/lint/rules/noImportAssign">noImportAssign (since v0.8.0)</a>
97+
<a href="/docs/lint/rules/noImportAssign">noImportAssign (since v0.9.0)</a>
9898
<a class="header-anchor" href="#noImportAssign"></a>
9999
<span class="recommended">recommended</span>
100100
</h3>

website/src/docs/lint/rules/noImportAssign.md

+12-26
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ title: Lint Rule noImportAssign
33
layout: layouts/rule.liquid
44
---
55

6-
# noImportAssign (since v0.8.0)
6+
# noImportAssign (since v0.9.0)
77

88
> This rule is recommended by Rome.
99
@@ -49,35 +49,21 @@ import y from "y";
4949

5050
```jsx
5151
import z from "y";
52-
({ z } = 1);
53-
```
54-
55-
{% raw %}<pre class="language-text"><code class="language-text"><span style="color: Orange;">warning</span><span style="color: Orange;">[</span><span style="color: Orange;"><a href="https://rome.tools/docs/lint/rules/noImportAssign/">js/noImportAssign</a></span><span style="color: Orange;">]</span><em>: </em><em>The imported variable </em><em><em>z</em></em><em> is read-only</em>
56-
<span style="color: rgb(38, 148, 255);">┌</span><span style="color: rgb(38, 148, 255);">─</span> js/noImportAssign.js:2:4
57-
<span style="color: rgb(38, 148, 255);">│</span>
58-
<span style="color: rgb(38, 148, 255);">1</span> <span style="color: rgb(38, 148, 255);">│</span> import z from &quot;y&quot;;
59-
<span style="color: rgb(38, 148, 255);">│</span> <span style="color: rgb(38, 148, 255);">-</span> <span style="color: rgb(38, 148, 255);">The variable is imported here</span>
60-
<span style="color: rgb(38, 148, 255);">2</span> <span style="color: rgb(38, 148, 255);">│</span> ({ z } = 1);
61-
<span style="color: rgb(38, 148, 255);">│</span> <span style="color: rgb(38, 148, 255);">-</span>
62-
63-
= note: Use a local variable instead of reassigning an import.
64-
65-
</code></pre>{% endraw %}
66-
67-
```jsx
52+
({ z } = 1); /// ```
53+
```js,expect_diagnostic
6854
import a from "y";
6955
[...a] = 1;
7056
```
7157

72-
{% raw %}<pre class="language-text"><code class="language-text"><span style="color: Orange;">warning</span><span style="color: Orange;">[</span><span style="color: Orange;"><a href="https://rome.tools/docs/lint/rules/noImportAssign/">js/noImportAssign</a></span><span style="color: Orange;">]</span><em>: </em><em>The imported variable </em><em><em>a</em></em><em> is read-only</em>
73-
<span style="color: rgb(38, 148, 255);">┌</span><span style="color: rgb(38, 148, 255);">─</span> js/noImportAssign.js:2:5
74-
<span style="color: rgb(38, 148, 255);">│</span>
75-
<span style="color: rgb(38, 148, 255);">1</span> <span style="color: rgb(38, 148, 255);">│</span> import a from &quot;y&quot;;
76-
<span style="color: rgb(38, 148, 255);">│</span> <span style="color: rgb(38, 148, 255);">-</span> <span style="color: rgb(38, 148, 255);">The variable is imported here</span>
77-
<span style="color: rgb(38, 148, 255);">2</span> <span style="color: rgb(38, 148, 255);">│</span> [...a] = 1;
78-
<span style="color: rgb(38, 148, 255);"></span> <span style="color: rgb(38, 148, 255);">-</span>
79-
80-
= note: Use a local variable instead of reassigning an import.
58+
{% raw %}<pre class="language-text"><code class="language-text"><span style="color: Tomato;">error</span><em>: </em><em>unterminated template literal</em>
59+
<span style="color: rgb(38, 148, 255);"></span><span style="color: rgb(38, 148, 255);"></span> js/noImportAssign.js:3:4
60+
<span style="color: rgb(38, 148, 255);"></span>
61+
<span style="color: rgb(38, 148, 255);">3</span> <span style="color: rgb(38, 148, 255);"></span> ```<span style="color: Tomato;">j</span><span style="color: Tomato;">s</span><span style="color: Tomato;">,</span><span style="color: Tomato;">e</span><span style="color: Tomato;">x</span><span style="color: Tomato;">p</span><span style="color: Tomato;">e</span><span style="color: Tomato;">c</span><span style="color: Tomato;">t</span><span style="color: Tomato;">_</span><span style="color: Tomato;">d</span><span style="color: Tomato;">i</span><span style="color: Tomato;">a</span><span style="color: Tomato;">g</span><span style="color: Tomato;">n</span><span style="color: Tomato;">o</span><span style="color: Tomato;">s</span><span style="color: Tomato;">t</span><span style="color: Tomato;">i</span><span style="color: Tomato;">c</span>
62+
<span style="color: rgb(38, 148, 255);">│</span> <span style="color: Tomato;">┌</span><span style="color: Tomato;">─</span><span style="color: Tomato;">─</span><span style="color: Tomato;"></span><span style="color: Tomato;">─</span><span style="color: Tomato;">^</span>
63+
<span style="color: rgb(38, 148, 255);">4</span> <span style="color: rgb(38, 148, 255);">│</span> <span style="color: Tomato;">│</span> <span style="color: Tomato;">i</span><span style="color: Tomato;">m</span><span style="color: Tomato;">p</span><span style="color: Tomato;">o</span><span style="color: Tomato;">r</span><span style="color: Tomato;">t</span><span style="color: Tomato;"> </span><span style="color: Tomato;">a</span><span style="color: Tomato;"> </span><span style="color: Tomato;">f</span><span style="color: Tomato;">r</span><span style="color: Tomato;">o</span><span style="color: Tomato;">m</span><span style="color: Tomato;"> </span><span style="color: Tomato;">&quot;</span><span style="color: Tomato;">y</span><span style="color: Tomato;">&quot;</span><span style="color: Tomato;">;</span>
64+
<span style="color: rgb(38, 148, 255);">5</span> <span style="color: rgb(38, 148, 255);">│</span> <span style="color: Tomato;">│</span> <span style="color: Tomato;">[</span><span style="color: Tomato;">.</span><span style="color: Tomato;">.</span><span style="color: Tomato;">.</span><span style="color: Tomato;">a</span><span style="color: Tomato;">]</span><span style="color: Tomato;"> </span><span style="color: Tomato;">=</span><span style="color: Tomato;"> </span><span style="color: Tomato;">1</span><span style="color: Tomato;">;</span>
65+
<span style="color: rgb(38, 148, 255);">6</span> <span style="color: rgb(38, 148, 255);">│</span> <span style="color: Tomato;">│</span>
66+
<span style="color: rgb(38, 148, 255);">│</span> <span style="color: Tomato;">└</span><span style="color: Tomato;">^</span>
8167
8268
</code></pre>{% endraw %}
8369

0 commit comments

Comments
 (0)