feat: add -t and -i flags to docker run command so that docker contai…

[MSevey]

…ner can be stopped with crtl c

Overview

Close #65

REF: https://forums.docker.com/t/docker-run-cannot-be-killed-with-ctrl-c/13108/4

  -i, --interactive                    Keep STDIN open even if not attached
  -t, --tty                            Allocate a pseudo-TTY

[jcstein]

utACK

[nashqueue]

          I think being able to stop it is useful with CTRL+C. however, it is also useful to be able to keep the container running if you exit the terminal. so, if being able to stop with CTRL+C doesn't also stop the container when you exit the terminal I think the PR is desirable

Originally posted by @jcstein in #65 (comment)

Cross-posting here to make sure it keeps running when you close the terminal

[nashqueue]

If you want to run a container in the background (no opened terminal required), use the parameter -d. You can still get the logs with docker logs ... and attach a terminal to a running container using docker attach ....

Originally posted by @smuu in #65 (comment)

Should we Add the flag -d ?

[nashqueue]

utAck

[smuu]

If you want to run a container in the background (no opened terminal required), use the parameter -d. You can still get the logs with docker logs ... and attach a terminal to a running container using docker attach ....

Originally posted by @smuu in #65 (comment)

Should we Add the flag -d ?

I don't think -d should be added by default. This will confuse people running this. Maybe we can add a comment that if someone wants to run it in the background, they can start it with the argument added.

[MSevey]

If you want to run a container in the background (no opened terminal required), use the parameter -d. You can still get the logs with docker logs ... and attach a terminal to a running container using docker attach ....
Originally posted by @smuu in #65 (comment)
Should we Add the flag -d ?

I don't think -d should be added by default. This will confuse people running this. Maybe we can add a comment that if someone wants to run it in the background, they can start it with the argument added.

defer to @jcstein on this

[jcstein]

I think I will follow the advice from @smuu and can add a note to the docs on using -d flag

@smuu can you confirm that the use of the -i and -t flags is something you think is worth adding?

[MSevey]

I think I will follow the advice from @smuu and can add a note to the docs on using -d flag

@smuu can you confirm that the use of the -i and -t flags is something you think is worth adding?

If we no longer need to copy anything from the logs (which is a UX we should maintain imo) then we should add these flags so that users can stop the docker container with crtl c, since that is a standard practice.

Otherwise users need to detach from the container and use docker stop.

Either way we should include how to stop the container in the README.

I'll update with my proposed solution.

[nashqueue]

LGTM

[nashqueue]

utAck

[jcstein]

ACK