Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl+c doesn't exit devnet #65

Closed
rootulp opened this issue Sep 19, 2023 · 4 comments · Fixed by #66
Closed

Ctrl+c doesn't exit devnet #65

rootulp opened this issue Sep 19, 2023 · 4 comments · Fixed by #66
Labels
bug Something isn't working

Comments

@rootulp
Copy link
Contributor

rootulp commented Sep 19, 2023

Context

I just a local devnet with the steps at https://github.com/rollkit/local-celestia-devnet#to-build-and-run-the-docker-image

Problem

I'm attempting to stop the devnet with Ctrl + C but that's not stopping the devnet. Notice the ^C in the terminal output:

^C7:57PM INF Timed out dur=10993.078792 height=14 module=consensus round=0 step=1
7:57PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"E3F0A48B96D9A48236EEECD0CA5D7B312F47620787844A13185BA1F51926E4A3","parts":{"hash":"653454D2A26B2FDF64CFEA23EC46B49F25F6F225545DB7ECA96B8756C402D587","total":1}},"height":14,"pol_round":-1,"round":0,"signature":"HvyIDuTbr/dftdMAaPkorWU/G+t+f4DVA1XErc1+0WuYXqCIrx1E6KaY7t/UWAFiMkMmW/SufCjdQxTc6rinAA==","timestamp":"2023-09-19T19:57:35.175358293Z"}
7:57PM INF received complete proposal block hash=E3F0A48B96D9A48236EEECD0CA5D7B312F47620787844A13185BA1F51926E4A3 height=14 module=consensus

To resolve I had to open Docker Dashboard and stop the container with

Screenshot 2023-09-19 at 3 57 24 PM

Question

Is this expected behavior? Is it possible for the devnet to stop if I Ctrl+C in terminal?

@nashqueue
Copy link
Member

This was desirable in the interim because we were printing out the Auth token and copying it from the logs. Not sure if that is still necessary, as we can extract it from docker through a command now. cc @jcstein

@jcstein
Copy link
Member

jcstein commented Sep 20, 2023

I think being able to stop it is useful with CTRL+C. however, it is also useful to be able to keep the container running if you exit the terminal. so, if being able to stop with CTRL+C doesn't also stop the container when you exit the terminal I think the PR is desirable

@smuu
Copy link
Contributor

smuu commented Sep 20, 2023

I think being able to stop it is useful with CTRL+C. however, it is also useful to be able to keep the container running if you exit the terminal. so, if being able to stop with CTRL+C doesn't also stop the container when you exit the terminal I think the PR is desirable

If you want to run a container in the background (no opened terminal required), use the parameter -d. You can still get the logs with docker logs ... and attach a terminal to a running container using docker attach ....

@rootulp rootulp closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
@jcstein
Copy link
Member

jcstein commented Oct 2, 2023

thanks for this issue @rootulp - it's much nicer to be able to stop the devnet with ctrl+c than using dashboard or something janky like docker stop $(docker ps -aq)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
5 participants