Match list of services in docs to Rockstor UI #460 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of services in our docs does not completely match the list present in Rockstor's UI: System > Services page. In the docs, some are missing, while the rest is not listed in the same order. This commit thus ensure a match in the services listed and their order between our docs and Rockstor UI.
|
2 linkcheck failures:
|
|
nextcloud is back up again apparently. This looks good to me. Thanks @FroggyFlox for cleaning this up. |
phillxnet
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
@FroggyFlox This is a long awaited improvement: much appreciated.
I've made a couple of minor suggestions re awareness of port selection.
See what you think - not show stoppers but may be worth popping in.
Co-authored-by: Philip Guyton <phillxnet@users.noreply.github.com>
Co-authored-by: Philip Guyton <phillxnet@users.noreply.github.com>
phillxnet
requested changes
Oct 24, 2023
|
Thanks for the review and the improvements! That's definitely an important point to add so I committed your suggestions. |
Co-authored-by: Philip Guyton <phillxnet@users.noreply.github.com>
|
@FroggyFlox & @Hooverdan96 Sphinx Link Check passed for he here !! |
|
PR product PRODUCTION published. |
FroggyFlox
added a commit
to FroggyFlox/rockstor-core
that referenced
this pull request
Oct 24, 2023
Some configurable services were still missing a help icon-link because they did not have a dedicated section in the docs. Since rockstor/rockstor-doc#462, all services have a doc section so this commit adds these missing help icons-links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460
@phillxnet, @Hooverdan96: ready for review.
This pull request's proposal
The list of services in our docs does not completely match the list present in Rockstor's UI: System > Services page. In the docs, some are missing, while the rest is not listed in the same order.
This pull request thus ensures a match in the services listed and their order between our docs and Rockstor UI.
Checklist