Add/Update help icon linking to docs #2720 #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the configuration modals for our Services, some include links to
their respective docs while other do not.
This commit harmonizes these discrepancies by adding the same help icon
linking to the Service's section in our docs.
Also includes:
- minor update of Tailscale service configuration header so that it
matches the other services
- update copyright statements
|
Linking to related, and now merged/published docs PR: |
phillxnet
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
@FroggyFlox A functional test via an rpm build. Thanks for this excellent use experience enhancement. And for the linked PR to arrange our docs end appropriately. Nice.
Successfully built an rpm against current testing branch.
Confirming that all Web-UI System -> Service spanner-icon-invoked config dialogs link to respective doc entries successfully.
|
@FroggyFlox I'll go ahead an merge this one then, as it's been ready for some time now I see. Otherwise we may end up encountering some unwelcome merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2720
In the configuration modals for our Services, some include links to their respective docs while other do not.
This pull requests harmonizes these discrepancies by adding the same help icon linking to the Service's section in our docs.
Also includes:
The configuration modals for all affected services were verified: