Replication secret encrypted in Web-UI #2759 #2764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special-case our internal cliapp re secret availability. Indicate all non-internal Access Key secrets as only available during creation. ## Includes - Surfacing our pass/PGP encrypted raw secret to authenticated Web-UI logins. - Indicate all other API credentials as not available. - Brevity improvements re deletion attempt on cliapp message.
|
This pending fix is required by / is a dependency for, the development of draft PR: I've now build a test rpm including this PR on a 15.5 base and all looks to be as intended. I.e. we now surface this 'special case', with the caveat that we need to follow this up re: Surface auto-generated access key secrets prior to save #2763 Given the above I'll merge this to ease ongoing development. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special-case our internal cliapp re secret availability. Indicate all non-internal Access Key secrets as only available during creation.
Closes #2759
Includes