Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface auto-generated access key secrets prior to save #2763

Open
phillxnet opened this issue Dec 13, 2023 · 1 comment
Open

Surface auto-generated access key secrets prior to save #2763

phillxnet opened this issue Dec 13, 2023 · 1 comment

Comments

@phillxnet
Copy link
Member

Since "Update django-oauth-toolkit #2710" #2727 we can no longer retrieve the raw secret we auto-generate when adding a new Access Key: - rendering this capability unusable. To re-enable this facility, it is proposed that we add the ability to present within the Web-UI, just prior to save, the proposed secret; with the ability to enter/edit.

Currently, during entry, we have:
add-access-key-dialog

where the associated access key ID & secret are auto-generated.

However give django-oauth-toolkits change of stance re it's storage & retrieval of this key, we must now manage these secrets ourselves. In the special case of our internal cliapp app we now alternatively manage the secret via OS provided pass: see:

Adopt dedicated secrets management library #2728 #2758

And ongoing issue: Replication secret encrypted in Web-UI #2759

But for external/custom Access Key additions we could simply present the proposed new Access Key secret (with enter/edit option) along with a warning indicating that its retrieval will: there-after no longer be possible. This is more in line with modern practice and informs the user that they are responsible for recording the generated/edited/entered secret, so that it might be transferred to the relevant external application; while hence forth no longer being accessible from the Rockstor instance.

@phillxnet
Copy link
Member Author

phillxnet commented Dec 13, 2023

The relevant UI template for this issue is as follows:

src/rockstor/storageadmin/static/storageadmin/js/templates/access_keys/add_access_key.jst

Given the sensitivity of this mechanism, and it's likely rather niche use, it may make for a good first htmx conversion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant