Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbus python dependency to latest #2744 #2745

Conversation

phillxnet
Copy link
Member

@phillxnet phillxnet commented Nov 14, 2023

Remove explicit pinning of dbus-python, enabling: 1.2.18 to 1.3.2 update as per poetry.lock.

Fixes #2744

Testing

See referenced issue commit: #2744 (comment)
All unit test pass.

Remove explicit pinning of dbus-python, enabling:
1.2.18 to 1.3.2 update as per poetry.lock.
@phillxnet
Copy link
Member Author

phillxnet commented Nov 14, 2023

A test 5.0.5-2745 RPM was build and installed successfully.

As this PR requires an sssd setup, a current omission in my test environment, I'm not able to test this adequately as it is my understanding that we only use dbus-python when interacting with sssd for its users/groups.

I was able to create & delete both a user and group using the PR RPM instantiated install.

@FroggyFlox & @Hooverdan96
I propose that we merge this to avoid hold-up of our pending Python/Django updates and from a quick look there doesn't appear to have be any breaking changes in this update (from changelog) - bar some Python 2 specific calls types. I would have expected them to error out during my exercise of users.py however, as they were removed: which should have broken the generation of a pyc file during the initial Python parsing of users.py.

We can then get testing channel feedback from folks that do have working sssd setups.

@FroggyFlox
Copy link
Member

Agreed. Thanks a lot for that work!

@phillxnet phillxnet merged commit 23a8df9 into rockstor:testing Nov 14, 2023
@phillxnet phillxnet deleted the 2744-Update-dbus-python-dependency-to-latest branch November 14, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants