Update dbus python dependency to latest

[phillxnet]

Our dbus-python dependency was previously constrained by our python version. This is not longer the case. We currently have:

dbus-python = "==1.2.18"

It is proposed, in the interests for issues such as

"Avoid system calls to interact with systemd services" #2680 where we have:

A better approach would most likely be to directly interact with systemd DBus. While we already have the dbus library as a dependency for interacting with the SSSD DBus responder InfoPipe, there is a python library to simplify interacting with systemd units and services: pystemd

While the linked issue, and proposed systemd dbus library, does not currently depend on dbus-python; it would never-the-less be advisable to unpin this library to enable our ongoing Python updates.

PyPi: https://pypi.org/project/dbus-python/
Project source: https://gitlab.freedesktop.org/dbus/dbus-python/
Project docs: https://dbus.freedesktop.org/doc/dbus-python/
Release history: https://dbus.freedesktop.org/doc/dbus-python/news.html#release-history

[phillxnet]

Removing our pinning give the following 'poetry update' result:

lbuildvm:/opt/rockstor # poetry update
Updating dependencies
Resolving dependencies... (7.8s)

Writing lock file

Package operations: 0 installs, 1 update, 0 removals

  • Updating dbus-python (1.2.18 -> 1.3.2)

Testing:

lbuildvm:/opt/rockstor/src/rockstor # export DJANGO_SETTINGS_MODULE=settings
lbuildvm:/opt/rockstor/src/rockstor # poetry run django-admin test -v 2
...
----------------------------------------------------------------------
Ran 278 tests in 30.095s

OK

[phillxnet]

@FroggyFlox & @Hooverdan96 I've just found the following upstream comment: https://gitlab.freedesktop.org/dbus/dbus-python/-/issues/48#note_2045548 from two months ago, as of this comment.

This project is only semi-maintained: merge requests welcome, but I am unlikely to be able to spend enough time on this to rewrite the tutorial.

As such we should look to limiting our use of this library, & ideally removing it in time.

I think users.py is currenlty the only user:

lbuildvm:/opt/rockstor/src # grep -R "import dbus"
rockstor/system/users.py:import dbus

[phillxnet]

Closing as:
Fixed by #2745