user admin enable without password change not internal error #2635 #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#2635 Return HTTP_400_BAD_REQUEST not HTTP_500_INTERNAL_SERVER_ERROR.
|
Merging this into testing to enable a rebase of the work in progress associated with the test improvements that brought this issue to light. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return HTTP_400_BAD_REQUEST not HTTP_500_INTERNAL_SERVER_ERROR.
Fixes #2635
Before proposed change
We return an internal server error code of 500 to our client side which results in our Web-UI providing a back-trace/debugging type feedback on an internal error that has not happened.
After patch
The change to a 400 bad client request error code results in the following more appropriate Web-UI dialog:
Counterpart unit test changes
This pull request and its associated issue address a small tested code modification surfaced while improving our tests in this area in work done against issue:
"Improve OS independence re unit tests #2633"
The appropriate testing change will be included in a referenced pull reqeust against that issue.