Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user admin enable without password change not internal error #2635

Closed
phillxnet opened this issue Aug 1, 2023 · 2 comments
Closed

user admin enable without password change not internal error #2635

phillxnet opened this issue Aug 1, 2023 · 2 comments
Assignees
@phillxnet

Comments

@phillxnet
Copy link
Member

When adding Web-UI admin to an existing user, without also changing the password, results in us responding as per HTTP 500, i.e. back trace and internal server error indication. What is more appropriate here is HTTP 400: client error. The client has not fulfilled the requirement to also submit a password while enabling Web-UI admin.
@phillxnet phillxnet self-assigned this Aug 1, 2023
@phillxnet phillxnet changed the title user admin enable without password change is not an internal error user admin enable without password change not internal error Aug 1, 2023
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Aug 1, 2023
@phillxnet
user admin enable without password change not internal error rockstor…
1a5e30e 
…#2635

Return HTTP_400_BAD_REQUEST not HTTP_500_INTERNAL_SERVER_ERROR.
@phillxnet
Copy link
Member Author

This issue is a spin-off from test improvements underway against issue:
"Improve OS independence re unit tests #2633"

@phillxnet phillxnet mentioned this issue Aug 1, 2023
Merged
phillxnet added a commit that referenced this issue Aug 1, 2023
@phillxnet
Merge pull request #2636 from phillxnet/2635_user_admin_enable_withou…
bd8f0b8 
…t_password_change_not_internal_error

user admin enable without password change not internal error #2635
@phillxnet
Copy link
Member Author

Closing as:
Fixed by #2636

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phillxnet