changelog fails on version lines. Fixes #2054 #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Improve Web-UI changelog parsing to account for both empty and release version line entries, the latter begin with "*". - Remove version lines filter mechanism in low level changelog parser.
|
Merging this as we are currently failing, within Web-UI, on our attribution responsibilities. And given we have quite a backlog of pull requests it would be good to get this in place ready for future releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously rockstor update rpm package changelog version lines were not passed to the Web-UI parsing code, and empty lines were rendered as inadvertent meaningless GitHub links. This pr is intended to resolve these issues by:
Fixes #2054
Testing:
Please see issue text and embedded images for functional tests performed using rpm packages containing relevant changelog entries (those dated accordingly).
Caveats:
Post this pull request we still have an outstanding issue (as yet not submitted to GitHub) where we fail to construct working GitHub links when more than a single issue is referenced, i.e as per the following example line: