-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changelog fails on version lines #2054
Comments
Tracking this further it seems we also don't pass the problematic lines to the above referenced view related files as logging indicates that the "# @" Web-UI elements come form blank entries returned from: /api/commands/update-check |
I have a local working solution to this issue. Noting to avoid duplication of effort. |
Example of pending pr output given pertinent changelog content within proposed package:
And via screen grab: |
- Improve Web-UI changelog parsing to account for both empty and release version line entries, the latter begin with "*". - Remove version lines filter mechanism in low level changelog parser.
…on_lines changelog fails on version lines. Fixes #2054
Web-UI presentation of pertinent rockstor changelog entries fails on version lines:
E.g.:
Given the following version line within an available rockstor update rpm package:
The resulting 'Software Updates' page counterpart displays:
This is due to incomplete parsing such that package version lines are treated as change item entries for historical reasons.
See template file:
https://github.com/rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/static/storageadmin/js/templates/update/version_info.jst
and associated view js file:
https://github.com/rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/static/storageadmin/js/views/version.js
i.e. in latter we have:
changeMap: this.changeLog(this.changeList),
Hence changelog in latter needs some attention for this issues resolution.
The text was updated successfully, but these errors were encountered: