Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog fails on version lines #2054

Closed
phillxnet opened this issue Jul 10, 2019 · 3 comments · Fixed by #2056
Closed

changelog fails on version lines #2054

phillxnet opened this issue Jul 10, 2019 · 3 comments · Fixed by #2056

Comments

@phillxnet
Copy link
Member

Web-UI presentation of pertinent rockstor changelog entries fails on version lines:

E.g.:
Given the following version line within an available rockstor update rpm package:

* Sun Feb 24 2019 Philip Guyton <philip@yewtreeapps.com> - 3.9.2-48

The resulting 'Software Updates' page counterpart displays:

# @

This is due to incomplete parsing such that package version lines are treated as change item entries for historical reasons.

See template file:
https://github.com/rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/static/storageadmin/js/templates/update/version_info.jst
and associated view js file:
https://github.com/rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/static/storageadmin/js/views/version.js

i.e. in latter we have:
changeMap: this.changeLog(this.changeList),

Hence changelog in latter needs some attention for this issues resolution.

@phillxnet
Copy link
Member Author

Tracking this further it seems we also don't pass the problematic lines to the above referenced view related files as logging indicates that the "# @" Web-UI elements come form blank entries returned from:

/api/commands/update-check

https://github.com/rockstor/rockstor-core/blob/master/src/rockstor/storageadmin/static/storageadmin/js/views/version.js#L67

@phillxnet
Copy link
Member Author

I have a local working solution to this issue. Noting to avoid duplication of effort.
Pull request to follow.

@phillxnet
Copy link
Member Author

Example of pending pr output given pertinent changelog content within proposed package:
(Actual changelog used is a work in progress as further merges are planned soon)

List of changes in this update
    * Tue Jul 9 13:00:00 2019 Philip Guyton - 3.9.2-49
    -Fix ENV display in RockonInstall_summary-table. Fixes #2029 @FroggyFlox
    -Fix size sorting on snapshots / shares pages. Fixes #1368 #1878 @Psykar
    -honour tag element within rock-on json. Fixes #2014 @phillxnet
    -pool resize disk removal unknown internal error and no UI counterpart. Fixes #1722 @phillxnet
    -[openSUSE] don't rely on PGDATA env var. Fixes #2041 @phillxnet
    * Sun Feb 24 12:00:00 2019 Philip Guyton - 3.9.2-48
    -Skip empty label fields. Fixes #2018 @FroggyFlox
    -Implement Add Labels feature for already-installed Rock-Ons. Fixes #1998 @FroggyFlox
    -regression in unit tests - environment outdated since 3.9.2-46. Fixes #1993 @phillxnet
    * Sun Feb 3 12:00:00 2019 Suman Chakravartula - 3.9.2-47
...

And via screen grab:

Changelog-Web-UI-fix

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 24, 2019
- Improve Web-UI changelog parsing to account for both empty and release
version line entries, the latter begin with "*".
- Remove version lines filter mechanism in low level changelog parser.
phillxnet added a commit that referenced this issue Sep 22, 2019
…on_lines

changelog fails on version lines. Fixes #2054
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant