minor regression in fake serial ui logic. Fixes#1086 #1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no mechanism that reads the disk UUID that relates to the reason this message comes up so to avoid confusion with actual disk UUID's remove reference to it in the warning message as it only pertains to no / fake serial.
schakrava
added a commit
that referenced
this pull request
Jan 10, 2016
…_serial_ui_logic minor regression in fake serial ui logic. Fixes#1086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore additional check that crept in while extensive UI updates were happening which caused a minor regression in the treatment of the new fake-serial mechanism used since #1045 .
N.B. I have also removed the reference to UUID in the serial warning message to reduce possible confusion with disk UUID as this message is only displayed when there are issues with disk serial and is not UUID related.
Fixes #1086