minor regression in fake serial ui logic #1086
Comments
|
I am about to address this issue and should have a pull / merge request ready shortly. |
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this issue
Jan 10, 2016
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this issue
Jan 10, 2016
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this issue
Jan 10, 2016
There is no mechanism that reads the disk UUID that relates to the reason this message comes up so to avoid confusion with actual disk UUID's remove reference to it in the warning message as it only pertains to no / fake serial.
phillxnet
added a commit
to phillxnet/rockstor-core
that referenced
this issue
Jan 10, 2016
|
Before and after above minor changes:-
|
|
Thank you @phillxnet! Really admire your ownership and quick turnaround on this one. |
|
@schakrava Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Prior to 3.8-10.15 we tested for our internal fake-serial drive flag and indicated it to be unreliable as we also do with null, empty, or serial == diskName however as of merge (pr) #1045 we also have to test for serial.length == 48 to catch our new flag mechanism of a 48 char fake-serial-uuid-derived-char-string.
See commit in above referenced pr:-
phillxnet@ce733be
From an initial look this seems like a minor change to line 208 in file :-
/src/rockstor/storageadmin/static/storageadmin/js/views/disks.js
is required as the display logic is now handled by a handlebar helper "display_disks_tbody".
The text was updated successfully, but these errors were encountered: