Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no drive name on custom smart options page #1756

Closed
phillxnet opened this issue Jul 11, 2017 · 2 comments
Closed

no drive name on custom smart options page #1756

phillxnet opened this issue Jul 11, 2017 · 2 comments
Assignees
@phillxnet
Labels
bug

Comments

@phillxnet
Copy link
Member

A cosmetic issue where the "Drive name:" field of the "Add drive specific custom S.M.A.R.T options" page is blank. There are no functional regressions associated with this cosmetic regression. This affects current stable channel release 3.9.1 and testing channel release 3.9.0-16 only (as of this issue report).

Linking to recent related pull requests:
#1747 (1746 disk api changes)
#1751 (minor disk api regression follow up. Fixes #1750)
and related issues:
#1746 "change disk api to use ids instead of names"
#1750 "minor disk api regression follow up"
@phillxnet
Copy link
Member Author

This same issue also affects the "Add drive specific Spin down time" page. Accessed via the hour glass icon in the disks page.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 11, 2017
@phillxnet
fix 'no drive name' regression on custom smart page rockstor#1756
a3e46a8 
A recent cosmetic regression from disk api changes.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 11, 2017
@phillxnet
fix 'no drive name' regression on spin down page rockstor#1756
fc24702 
A recent cosmetic regression from disk api changes.
@phillxnet
Copy link
Member Author

The associated commits address both 'missing name' fields observed so far. I will prepare a pr shortly.

@phillxnet phillxnet mentioned this issue Jul 12, 2017
Merged
schakrava added a commit that referenced this issue Jul 18, 2017
@schakrava
Merge pull request #1758 from phillxnet/1756_no_drive_name_on_custom_…
93c9f22 
…smart_options_page

no drive name on custom smart options and spin down pages. Fixes #1756
@schakrava schakrava added the bug label Jul 18, 2017
@schakrava schakrava added this to the Panamint Valley milestone Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schakrava @phillxnet