Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor disk api regression follow up #1750

Closed
phillxnet opened this issue Jul 2, 2017 · 2 comments · Fixed by #1751
Closed

minor disk api regression follow up #1750

phillxnet opened this issue Jul 2, 2017 · 2 comments · Fixed by #1751
Assignees
@phillxnet
Labels
bug
Milestone
Point Bonita

Comments

@phillxnet
Copy link
Member

phillxnet commented Jul 2, 2017 •
edited
Loading

An umbrella issue to address minor followup changes to recent important disk api changes.

  1. Partitioned device indicator (tags icon) in Create Pool dialog - link error
  2. Open LUKS volume indicator (eye-open icon) in Create Pool dialog - link error
  3. Certain 'Exception' import conditions lead to "%d format: a number is required, not unicode" (disk.py L489 / L711 _btrfs_disk_import).
  4. S.MA.R.T custom option api url format needs updating.
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 2, 2017
@phillxnet
update 'create pool' dev table to use new format links rockstor#1750
3e40a87
phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 2, 2017
@phillxnet
update S.MA.R.T custom options - new api url format rockstor#1750
dc21d13
@phillxnet
Copy link
Member Author

1, 2, and 4 are now sorted by the attached commits.

Currently looking for a reproducer of 3 as shortly after experiencing the reported error the import worked as expected.

@phillxnet
Copy link
Member Author

@schakrava To me it looks like our 'did' is actually of type unicode. I'm going ahead and changing our Exception msg casting. I'll try and catch all in a single commit in case I have this backwards some how.

phillxnet added a commit to phillxnet/rockstor-core that referenced this issue Jul 2, 2017
@phillxnet
disk id as string in Exception messages rockstor#1750
3ae84a1
@phillxnet phillxnet mentioned this issue Jul 2, 2017
Merged
schakrava added a commit that referenced this issue Jul 2, 2017
@schakrava
Merge pull request #1751 from phillxnet/1750_minor_disk_api_regressio…
0bc9216 
…n_follow_up

minor disk api regression follow up. Fixes #1750
@schakrava schakrava added the bug label Jul 2, 2017
@schakrava schakrava added this to the Point Bonita milestone Jul 2, 2017
This was referenced Jul 11, 2017
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phillxnet phillxnet

Labels
bug
Projects
None yet
Milestone
Point Bonita
Development

Successfully merging a pull request may close this issue.

minor disk api regression follow up. Fixes #1750 phillxnet/rockstor-core
2 participants
@schakrava @phillxnet