chore: update to upstream v0.42.0 release #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d22271 to
4eefe7d
Compare
|
Tests are failing due to what looks like a leaked goroutine. I've been unable to recreate the goroutine leak outside of GitHub actions. Marking the tests as skipped here for the time being, as they're tested successfully in the upstream extension. |
67814db to
3beca85
Compare
|
Remaining checks are failing as they are attempting to read secrets from the upstream repo. They are all part of the |
9aa12e4 to
6acf93e
Compare
6acf93e to
df4c9c5
Compare
2d3cbca to
f197c07
Compare
tanuck
approved these changes
Jan 15, 2025
The implicit expectation of the ConfigTest is that the underlying credentials provider will come from the mockCredentials struct. This change constructs the testdata config in such a way as to make this happen. Needs refactoring to remove this implicit contract.
f197c07 to
23ed32b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates main branch to v0.42.0 upstream release
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.