Skip to content

Commit

Permalink
figuring out which test is leaking a goroutine
Browse files Browse the repository at this point in the history
  • Loading branch information
danmrichards committed Jan 6, 2025
1 parent 4eefe7d commit 3beca85
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/PR-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ jobs:
- name: Set testRef output
id: setRef
run: |
if [[ ${{ github.base_ref }} == release/v* ]]; then
if [[ ${{ github.base_ref }} == release/v* ]]; then
echo "ref=${{github.base_ref}}" >> $GITHUB_OUTPUT
else
echo "ref=terraform" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -299,7 +299,7 @@ jobs:

- name: Get all the testing suites
id: set-matrix
run: |
run: |
matrix=$(python e2etest/get-testcases.py local_matrix)
echo "matrix=$matrix" >> $GITHUB_OUTPUT
Expand Down
2 changes: 2 additions & 0 deletions extensions/newsigv4/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ func TestLoadConfig(t *testing.T) {
}

func TestLoadConfigError(t *testing.T) {
t.Skip("Skippping as somewhere in the stack a goroutine is being leaked when running in CI")

cm, err := confmaptest.LoadConf(filepath.Join("testdata", "config.yaml"))
require.NoError(t, err)
factory := NewFactory()
Expand Down
2 changes: 2 additions & 0 deletions extensions/newsigv4/extension_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,8 @@ func TestPerRPCCredentials(t *testing.T) {
}

func TestGetCredsProviderFromConfig(t *testing.T) {
t.Skip("Skippping as somewhere in the stack a goroutine is being leaked when running in CI")

tests := []struct {
name string
cfg *Config
Expand Down

0 comments on commit 3beca85

Please sign in to comment.