Fix (some) odoc warnings #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75290cd to
8531415
Compare
|
I rebased your PR. Seems ok me, let's see the CI and I will waiting to see this PR as ready 👍. |
mbarbin
commented
Jan 7, 2025
mbarbin
commented
Jan 7, 2025
|
I enabled for review, modulo just 2 simple remarks, which I just added a review comment. If you are happy with it, I am too. Thanks for looking into the PR! |
|
Ok the PR is ready merge, let's go 👍. |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 13, 2025
CHANGES: - Notice the domain if it needs to look into the shared heap if a task is ready to be transfered (@dinosaure, robur-coop/miou#41) - Don't use `Option.value` but `match .. with` to calculate the optional length for `Miou_unix.{read,write}` (@kit-ty-kate, robur-coop/miou#44) - Use `List.iter` instead of `Hashtbl.iter` for internal kept file-descriptors of `Miou_unix` (@dinosaure, robur-coop/miou#45) - Improve the documentation of `Miou_unix` about suspended syscalls (@dinosaure, @kit-ty-kate, robur-coop/miou#43) - Export `reraise` (@dinosaure, robur-coop/miou#46) - Fix an issue on the `dom0` and observe if some tasks must be transfered to it (@dinosaure, robur-coop/miou#48) - Fix documentation (@mbarbin, robur-coop/miou#47) - Fix the formatter (@mbarbin, robur-coop/miou#51) - Upgrade miou to `ocamlformat.0.27.0` (@mbarbin, robur-coop/miou#52) - Add `x-maintenance-intent` (@hannesm, robur-coop/miou#56) - Improve the documentation and some `odoc` warnings (@mbarbin, robur-coop/miou#53, robur-coop/miou#54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a number of warnings when building the
doctarget locally and thought I would attempt to look into it.As it turns out, most warnings of the unresolvedroot kind look like bugs. For example:
Instead of pursuing those, I switched to compiling the
doc-newtarget instead, which I presume, by bringing external dependencies into the scope, resolves these kinds of warnings. I then focused on fixing the remaining warnings only.There remain 2 at the tip of the PR, but I believe they come from external dependencies, so there's no point in trying to solve them here.