Outperform the way to consume tasks by domains #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mains) only when it's needed. On benchmarks, the mutex (system) has a huge cost. This patch add a new atomic into the pool to set to false when the shared queue is not empty. In this case, all domains fallback to the worker function to consume all pending tasks available into the shared queue. Otherwise, domains just consume their own internal queues until they are empty. We keep the behavior that when something appears into the shared queue, domains (all domains) introspects this shared queue in the exclusive way (via the mutex). The test30 shows the case of a cancellation across domains and where one of our domains should consume this task from the shared queue and do, as soon as possible, the cancellation.
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Jan 13, 2025
CHANGES: - Notice the domain if it needs to look into the shared heap if a task is ready to be transfered (@dinosaure, robur-coop/miou#41) - Don't use `Option.value` but `match .. with` to calculate the optional length for `Miou_unix.{read,write}` (@kit-ty-kate, robur-coop/miou#44) - Use `List.iter` instead of `Hashtbl.iter` for internal kept file-descriptors of `Miou_unix` (@dinosaure, robur-coop/miou#45) - Improve the documentation of `Miou_unix` about suspended syscalls (@dinosaure, @kit-ty-kate, robur-coop/miou#43) - Export `reraise` (@dinosaure, robur-coop/miou#46) - Fix an issue on the `dom0` and observe if some tasks must be transfered to it (@dinosaure, robur-coop/miou#48) - Fix documentation (@mbarbin, robur-coop/miou#47) - Fix the formatter (@mbarbin, robur-coop/miou#51) - Upgrade miou to `ocamlformat.0.27.0` (@mbarbin, robur-coop/miou#52) - Add `x-maintenance-intent` (@hannesm, robur-coop/miou#56) - Improve the documentation and some `odoc` warnings (@mbarbin, robur-coop/miou#53, robur-coop/miou#54)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.