Set the output pipe as a non-block fd and catch EAGAIN when we write into it #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haesbaert
reviewed
Jun 13, 2024
haesbaert
reviewed
Jun 13, 2024
haesbaert
approved these changes
Jun 13, 2024
haesbaert
reviewed
Jun 17, 2024
| @@ -330,10 +330,11 @@ let transmit_fds signals revert tbl fds = | |||
| List.fold_left fold signals fds | |||
|
|
|||
| let interrupted fd fds = List.exists (( = ) fd) fds | |||
| let buf = Bytes.create 0x1000 | |||
There was a problem hiding this comment.
That's not a great idea, sorry I might I have failed to express myself before.
I'd pre-allocate this per-domain, on whatever structure you have that holds per-domain data.
If you just use a global one, you're basically concurrently writing to the buf from multiple domains, which is not a great idea, it's likely not a a bug per-se because of the current implementation of Bytes where it just copes, but it's an antipattern on the very least.
There was a problem hiding this comment.
Yes, I was too fast about my last commit, I will fix that and revert as before. Thrme allocation of a small one does not cost too much.
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Aug 22, 2024
CHANGES: - Set the internal pipe used to interrupt a domain to a non-blocking mode and remove the usage of an atomic which protect how we fill the pipe (@haesbaert, @dinosaure, robur-coop/miou#28) - Expose option to reuse addr/port when we `Miou_unix.bind_and_listen` (@ada2k, @dinosaure, robur-coop/miou#27) - Protect an illegal access to the orphan from a possibly parallel task which does not own the orphan value (@poytypic, @dinosaure, robur-coop/miou#31, robur-coop/miou#32) - Be able to pin a specific domain when we want to launch a parallel task (@dinosaure, robur-coop/miou#34) - Expose the `Miou.Backoff` module which can be useful for users (@dinosaure, robur-coop/miou#35) - Fix or improve (from the maintainance point-of-view) the `Miou.Queue` module and some internal parts of Miou about the usage of atomics (@dinosaure, @polytypic, robur-coop/miou#36, robur-coop/miou#33) - Prefer to require a `finaliser` function for the `events` value and actually close the internal `Unix.pipe` used to interrupt domain than to use `Gc.finaliser` and possibly leak file-descriptors (spotted by @hannesm, @dinosaure, robur-coop/miou#37)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this pull request
Sep 5, 2024
CHANGES: - Set the internal pipe used to interrupt a domain to a non-blocking mode and remove the usage of an atomic which protect how we fill the pipe (@haesbaert, @dinosaure, robur-coop/miou#28) - Expose option to reuse addr/port when we `Miou_unix.bind_and_listen` (@ada2k, @dinosaure, robur-coop/miou#27) - Protect an illegal access to the orphan from a possibly parallel task which does not own the orphan value (@poytypic, @dinosaure, robur-coop/miou#31, robur-coop/miou#32) - Be able to pin a specific domain when we want to launch a parallel task (@dinosaure, robur-coop/miou#34) - Expose the `Miou.Backoff` module which can be useful for users (@dinosaure, robur-coop/miou#35) - Fix or improve (from the maintainance point-of-view) the `Miou.Queue` module and some internal parts of Miou about the usage of atomics (@dinosaure, @polytypic, robur-coop/miou#36, robur-coop/miou#33) - Prefer to require a `finaliser` function for the `events` value and actually close the internal `Unix.pipe` used to interrupt domain than to use `Gc.finaliser` and possibly leak file-descriptors (spotted by @hannesm, @dinosaure, robur-coop/miou#37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @haesbaert this is my first try to fix the pipe used to interrupt a domain. WDYT?