orphans is not domain-safe.
#31
Comments
|
Fixed by #32 |
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this issue
Aug 22, 2024
CHANGES: - Set the internal pipe used to interrupt a domain to a non-blocking mode and remove the usage of an atomic which protect how we fill the pipe (@haesbaert, @dinosaure, robur-coop/miou#28) - Expose option to reuse addr/port when we `Miou_unix.bind_and_listen` (@ada2k, @dinosaure, robur-coop/miou#27) - Protect an illegal access to the orphan from a possibly parallel task which does not own the orphan value (@poytypic, @dinosaure, robur-coop/miou#31, robur-coop/miou#32) - Be able to pin a specific domain when we want to launch a parallel task (@dinosaure, robur-coop/miou#34) - Expose the `Miou.Backoff` module which can be useful for users (@dinosaure, robur-coop/miou#35) - Fix or improve (from the maintainance point-of-view) the `Miou.Queue` module and some internal parts of Miou about the usage of atomics (@dinosaure, @polytypic, robur-coop/miou#36, robur-coop/miou#33) - Prefer to require a `finaliser` function for the `events` value and actually close the internal `Unix.pipe` used to interrupt domain than to use `Gc.finaliser` and possibly leak file-descriptors (spotted by @hannesm, @dinosaure, robur-coop/miou#37)
avsm
pushed a commit
to avsm/opam-repository
that referenced
this issue
Sep 5, 2024
CHANGES: - Set the internal pipe used to interrupt a domain to a non-blocking mode and remove the usage of an atomic which protect how we fill the pipe (@haesbaert, @dinosaure, robur-coop/miou#28) - Expose option to reuse addr/port when we `Miou_unix.bind_and_listen` (@ada2k, @dinosaure, robur-coop/miou#27) - Protect an illegal access to the orphan from a possibly parallel task which does not own the orphan value (@poytypic, @dinosaure, robur-coop/miou#31, robur-coop/miou#32) - Be able to pin a specific domain when we want to launch a parallel task (@dinosaure, robur-coop/miou#34) - Expose the `Miou.Backoff` module which can be useful for users (@dinosaure, robur-coop/miou#35) - Fix or improve (from the maintainance point-of-view) the `Miou.Queue` module and some internal parts of Miou about the usage of atomics (@dinosaure, @polytypic, robur-coop/miou#36, robur-coop/miou#33) - Prefer to require a `finaliser` function for the `events` value and actually close the internal `Unix.pipe` used to interrupt domain than to use `Gc.finaliser` and possibly leak file-descriptors (spotted by @hannesm, @dinosaure, robur-coop/miou#37)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
About
orphans, the underlyingSequence.tused is not domain-safe. Even if a parallel insertion is forbidden due to Miou's rules, the ability to insert a bad promise into theorphansSequence.tcan lead to an undefined behavior: so we should protectorphansagainst a bad use. Spotted by @polytypic.The text was updated successfully, but these errors were encountered: