Revert "remove thrift/ in include and fix compilation with YARP 3.2.101" #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit aa991c5.
This was referenced Dec 16, 2019
|
With this PR I also update Travis MacOS test to use |
This was referenced Dec 16, 2019
Closed
|
Did you verified that this version compiles fine with YARP 3.3 ? |
traversaro
approved these changes
Dec 16, 2019
Isn't it the current |
yarp-3.3 is slightly behind the current master (see https://github.com/robotology/yarp/tree/yarp-3.3) but for the purpose of this fix probably they can be considered equivalent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #65 for fixing #56 as suggested in robotology/yarp#2142 (comment)