Compilation failing against YARP devel and master #56

lrapetti · 2019-10-09T12:57:26Z

See https://travis-ci.org/robotology/wearables/builds/595555081?utm_medium=notification&utm_source=email. The Travis CI seems to be broken on MacOS, probably after some update in YARP.

traversaro · 2019-10-23T09:07:48Z

~~I guess this is related to robotology/yarp#2044 , even if I am not sure why it fails only in some specific case.~~

traversaro · 2019-10-23T09:14:40Z

~~Other possibly related issues: robotology/yarp#2110 .~~

traversaro · 2019-10-23T09:18:44Z

Actually I think that the regression was introduced by robotology/yarp#2102 , and the reason why it is not failing in Travis/Linux is that Linux is using an old version of YARP due to the docker caching.

lrapetti · 2019-10-24T13:07:55Z

As an initial step I am restoring the CI to the standard deps branches (#58) so that the CI for the master should be fixed. I will then investigate further the compatibility with YARP devel.

lrapetti · 2019-10-25T16:23:26Z

Actually I think that the regression was introduced by robotology/yarp#2102 , and the reason why it is not failing in Travis/Linux is that Linux is using an old version of YARP due to the docker caching.

I confirm the regression in introduced by this commit

traversaro · 2019-11-06T21:55:48Z

As the upstream issue is not really progressing, I would strongly suggest to have some sort of local workaround that fixes the build for the time being, for example by modifying the include to be include "WearableData.h", and modify the CMake script in

wearables/msgs/CMakeLists.txt

Line 34 in f52a9e1

list(APPEND WEARABLEDATA_INCLUDE_DIRS ${parent_dir_path})

to have in WEARABLEDATA_INCLUDE_DIRS the necessary directories to be compatible both with YARP 3.2 and the future YARP 3.3 .

lrapetti · 2019-11-07T09:26:59Z

I would strongly suggest to have some sort of local workaround that fixes the build for the time being, for example by modifying the include to be include "WearableData.h"

I tried this fix, the problem is that the same problem is raised for the include of the generated WearableData.h:

/Users/lorenzorapetti/Software/robotology-superbuild/build/robotology/wearables/msgs/thrift/wearable/msg/WearableData.h:19:10: fatal error: 
      'thrift/wearable/msg/Accelerometer.h' file not found
#include <thrift/wearable/msg/Accelerometer.h>

In fact in its header it includes all the other thrift messages:

#include <thrift/wearable/msg/FreeBodyAccelerationSensor.h>
#include <thrift/wearable/msg/Gyroscope.h>
#include <thrift/wearable/msg/Magnetometer.h>
#include <thrift/wearable/msg/OrientationSensor.h>
#include <thrift/wearable/msg/PoseSensor.h>
#include <thrift/wearable/msg/PositionSensor.h>
#include <thrift/wearable/msg/SkinSensor.h>
#include <thrift/wearable/msg/TemperatureSensor.h>
#include <thrift/wearable/msg/Torque3DSensor.h>
#include <thrift/wearable/msg/VirtualJointKinSensor.h>
#include <thrift/wearable/msg/VirtualLinkKinSensor.h>
#include <thrift/wearable/msg/VirtualSphericalJointKinSensor.h>

and modify the CMake script in

wearables/msgs/CMakeLists.txt

Line 34 in f52a9e1

list(APPEND WEARABLEDATA_INCLUDE_DIRS ${parent_dir_path})

to have in WEARABLEDATA_INCLUDE_DIRS the necessary directories to be compatible both with YARP 3.2 and the future YARP 3.3 .

Here to you mean for example to add also the parent directory of the thrift directory?

traversaro · 2019-11-07T09:35:09Z

Here to you mean for example to add also the parent directory of the thrift directory?

Exactly. Just to understand, with YARP 3.3 , the include headers contain the thrift directory, but then the generated file is not in the thrift directory? This is even worse, for better visibility I suggest to open a new YARP issue instead of just commenting an old closed PR.

An alternative for the problem may be to move the *.thrift files outside of the thrift directory, perhaps that will work with both YARP 3.2 and 3.3 .

lrapetti · 2019-11-11T14:40:37Z

for better visibility I suggest to open a new YARP issue instead of just commenting an old closed PR.

new PR opened at robotology/yarp#2118.

lrapetti · 2019-11-11T15:13:00Z

Exactly. Just to understand, with YARP 3.3 , the include headers contain the thrift directory, but then the generated file is not in the thrift directory?

No, what happen is that all the generated files (e.g. Accelerometer.cpp, Accelerometer.h, WearableData.h, WearableData.cpp) are in the same folder build/robotology/wearable/msgs/thrift/wearable/msg, but still the WearableData.h cannot find the headers of the other generated messages with the error message above:

/Users/lorenzorapetti/Software/robotology-superbuild/build/robotology/wearables/msgs/thrift/wearable/msg/WearableData.h:19:10: fatal error: 
      'thrift/wearable/msg/Accelerometer.h' file not found
#include <thrift/wearable/msg/Accelerometer.h>

An alternative for the problem may be to move the *.thrift files outside of the thrift directory, perhaps that will work with both YARP 3.2 and 3.3 .

Same happen in this situation, and what change is just that the folder in which they are is: build/robotology/wearable/msgs/wearable/msg, and I am getting the error:

In file included from /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/src/IWearRemapper.cpp:12:
/Users/lorenzorapetti/Software/robotology-superbuild/build/robotology/wearables/msgs/wearable/msg/WearableData.h:19:10: fatal error: 'wearable/msg/Accelerometer.h' file not found
#include <wearable/msg/Accelerometer.h>

traversaro · 2019-11-11T15:31:28Z

Can't you just pass build/robotology/wearable/msgs as additonal include directory?

traversaro · 2019-11-11T15:32:58Z

Or any directory that is necessary to make sure that everything is correctly included.

lrapetti · 2019-11-12T10:41:24Z

I am trying to fix the compilation with YARP devel:

the first step was to remove the thrift/ scoping so that we avoid the problem of differeces between master and devel. This was achieved with lrapetti@d89d6ea that was tested comipiling in master. I can see in case of using master all the generated .h messages have the include without any scoping . In case of using YARP devel however, all of them are generated using wearable/msg/ scoping, and indeed the following error is raised:
```
In file included from /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/wrappers/IWear/src/IWearWrapper.cpp:11:
/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/wearable/msg/WearableData.h:19:10: fatal error: 'wearable/msg/Accelerometer.h' file not found
#include <wearable/msg/Accelerometer.h>
```
to avoid that error I tried to add the path to the include directory, as @traversaro suggested, adding list(APPEND WEARABLEDATA_INCLUDE_DIRS ${CMAKE_CURRENT_BINARY_DIR}/msgs/thrift/wearable/msg) in lrapetti@a868e32, and it was able to compile all the messages in YARP devel. However, it results in the following error:
```
/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/src/IWearRemapper.cpp:12:10: fatal error: 'WearableData.h' file not found
#include "WearableData.h"
```
and the same error results when trying to compile with YARP master.

traversaro · 2019-11-12T11:44:48Z

Can't we append the directory of the generation of the WearableData.h file in the include directories as well, or change the #include "WearableData.h" line to have a path compatible with the used include dirs (for example by copying from whatever stile is used in the generated WearableData.cpp?).

lrapetti · 2019-11-12T11:48:21Z

Can't we append the directory of the generation of the WearableData.h file in the include directories as well

I tried also this, but then it was failing to find IWearRemapper.h from the generated yarp_plugin_iwear_remapper.cpp. However I will double check.

or change the #include "WearableData.h" line to have a path compatible with the used include dirs (for example by copying from whatever stile is used in the generated WearableData.cpp?).

The problem is that this path would be different using YARP master or devel

traversaro · 2019-11-12T11:51:01Z

I tried also this, but then it was failing to find IWearRemapper.h from the generated yarp_plugin_iwear_remapper.cpp. However I will double check.

This seems to be a different problem.

The problem is that this path would be different using YARP master or devel

Ack, then it is not ideal, but if this is the only viable option you can also have an #ifdef from a definition that you can pass from CMake using target_compile_definitions depending on the YARP version.

lrapetti · 2019-11-12T11:56:09Z

Can't we append the directory of the generation of the WearableData.h file in the include directories as well

Anyway, I am not understating why I have this problem also in YARP master after adding the path for including the generated messages (i.e. after lrapetti@a868e32), while previously to that commit It is compiling without any error in master.

traversaro · 2019-11-12T12:37:04Z

Can't we append the directory of the generation of the WearableData.h file in the include directories as well

Anyway, I am not understating why I have this problem also in YARP master after adding the path for including the generated messages (i.e. after lrapetti@a868e32), while previously to that commit It is compiling without any error in master.

I am not really sure, probably inspecting directly the command line parameters passed to the compiler for the compilation unit that is failing (for make via VERBOSE=1 make) may provide useful information.

traversaro · 2019-11-12T13:40:01Z

@lrapetti let me know if you need any f2f help.

lrapetti · 2019-11-12T13:55:19Z

Using verbose I notice something strange, in fact there is a path that is repeated twice: -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/msgs/thrift/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/include. The complete output is:

[ 75%] Building CXX object devices/IWearRemapper/CMakeFiles/IWearRemapper.dir/src/IWearRemapper.cpp.o
cd /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/devices/IWearRemapper && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DIWearRemapper_EXPORTS -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/include -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/interfaces/IWear/include -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/msgs/thrift/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/include -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/msgs/thrift/wearable/msg -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/impl/SensorsImpl/include -isystem /Users/lorenzorapetti/Software/robotology-superbuild/build/install/include  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fPIC   -std=gnu++14 -o CMakeFiles/IWearRemapper.dir/src/IWearRemapper.cpp.o -c /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/src/IWearRemapper.cpp
/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/src/IWearRemapper.cpp:12:10: fatal error: 
      'WearableData.h' file not found
#include "WearableData.h"

While before that commit there is not that wrong path, while there is the correct included path -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/include:

[ 75%] Building CXX object devices/IWearRemapper/CMakeFiles/IWearRemapper.dir/src/IWearRemapper.cpp.o
cd /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/devices/IWearRemapper && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++  -DIWearRemapper_EXPORTS -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/include -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/interfaces/IWear/include -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/include -I/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/impl/SensorsImpl/include -isystem /Users/lorenzorapetti/Software/robotology-superbuild/build/install/include  -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fPIC   -std=gnu++14 -o CMakeFiles/IWearRemapper.dir/src/IWearRemapper.cpp.o -c /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/devices/IWearRemapper/src/IWearRemapper.cpp

so probably that strange path is due to te command list(APPEND WEARABLEDATA_INCLUDE_DIRS ${CMAKE_CURRENT_BINARY_DIR}/msgs/thrift/wearable/msg)?

traversaro · 2019-11-12T13:56:47Z

This is interesting, can you print WEARABLEDATA_INCLUDE_DIRS before and after the list(APPEND ..).

lrapetti · 2019-11-12T14:13:06Z

This is interesting, can you print WEARABLEDATA_INCLUDE_DIRS before and after the list(APPEND ..).

WEARABLEDATA_INCLUDE_DIRS= /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/include
WEARABLEDATA_INCLUDE_DIRS= /Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/include;/Users/lorenzorapetti/Software/robotology-superbuild/robotology/wearables/build/msgs/thrift/msgs/thrift/wearable/msg

traversaro · 2019-12-04T12:03:32Z

Apparently there has been another regression related to this, see robotology/yarp#2118 (comment) .

lrapetti · 2019-12-17T10:02:40Z

With #71 the new regression should be addressed. Closing the issue.

lrapetti added this to the Iteration 29 milestone Oct 9, 2019

This was referenced Oct 20, 2019

Is there a branch compatible with YARP unstable branch? #57

Closed

yarp_add_idl adds an extra thrift in the include folder robotology/yarp#2044

Closed

traversaro changed the title ~~CI failing on MacOS~~ CI failing on MacOS and on robotology-superbuild unstable branches Oct 23, 2019

traversaro changed the title ~~CI failing on MacOS and on robotology-superbuild unstable branches~~ Compilation failing against YARP devel Oct 23, 2019

traversaro mentioned this issue Oct 24, 2019

Add CI for unstable branches robotology/robotology-superbuild#277

Merged

lrapetti mentioned this issue Oct 25, 2019

yarpidl_thrift/YarpIDL.cmake: Allow "standard" file placements robotology/yarp#2102

Merged

lrapetti mentioned this issue Nov 11, 2019

Failure finding thrifth headers in YARP3.3 robotology/yarp#2118

Closed

lrapetti self-assigned this Nov 11, 2019

lrapetti mentioned this issue Nov 12, 2019

Expose thrift msgs to other applications and add Retargeting visualization yarpmanager application robotology/human-dynamics-estimation#155

Merged

claudia-lat modified the milestones: Iteration 29, Iteration 30 Nov 13, 2019

This was referenced Nov 14, 2019

Fix compilation with YARP 3.2.101 #65

Merged

Fix sampling-rate passing trough configuration #67

Merged

lrapetti closed this as completed in #65 Nov 22, 2019

traversaro mentioned this issue Nov 26, 2019

Compilation fails against YARP 3.2.101 (upcoming 3.3) robotology/human-dynamics-estimation#162

Closed

traversaro mentioned this issue Dec 4, 2019

HUMAN_DYNAMICS component build fails robotology/robotology-superbuild#313

Closed

lrapetti reopened this Dec 5, 2019

claudia-lat modified the milestones: Iteration 30, Iteration 31 Dec 10, 2019

lrapetti changed the title ~~Compilation failing against YARP devel~~ Compilation failing against YARP devel and master Dec 16, 2019

lrapetti mentioned this issue Dec 16, 2019

Revert "remove thrift/ in include and fix compilation with YARP 3.2.101" #71

Merged

lrapetti closed this as completed Dec 17, 2019

traversaro mentioned this issue Feb 3, 2020

Compilation failed on iCubGenova04 laptop (icub30) #78

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Compilation failing against YARP devel and master #56

Compilation failing against YARP devel and master #56

lrapetti commented Oct 9, 2019

traversaro commented Oct 23, 2019 •

edited

Loading

traversaro commented Oct 23, 2019 •

edited

Loading

traversaro commented Oct 23, 2019 •

edited

Loading

lrapetti commented Oct 24, 2019

lrapetti commented Oct 25, 2019

traversaro commented Nov 6, 2019

lrapetti commented Nov 7, 2019

traversaro commented Nov 7, 2019 •

edited

Loading

lrapetti commented Nov 11, 2019

lrapetti commented Nov 11, 2019

traversaro commented Nov 11, 2019

traversaro commented Nov 11, 2019

lrapetti commented Nov 12, 2019

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019 •

edited

Loading

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019

traversaro commented Nov 12, 2019

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019 •

edited

Loading

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019

traversaro commented Dec 4, 2019

lrapetti commented Dec 17, 2019

Compilation failing against YARP devel and master #56

Compilation failing against YARP devel and master #56

Comments

lrapetti commented Oct 9, 2019

traversaro commented Oct 23, 2019 • edited Loading

traversaro commented Oct 23, 2019 • edited Loading

traversaro commented Oct 23, 2019 • edited Loading

lrapetti commented Oct 24, 2019

lrapetti commented Oct 25, 2019

traversaro commented Nov 6, 2019

lrapetti commented Nov 7, 2019

traversaro commented Nov 7, 2019 • edited Loading

lrapetti commented Nov 11, 2019

lrapetti commented Nov 11, 2019

traversaro commented Nov 11, 2019

traversaro commented Nov 11, 2019

lrapetti commented Nov 12, 2019

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019 • edited Loading

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019

traversaro commented Nov 12, 2019

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019 • edited Loading

traversaro commented Nov 12, 2019

lrapetti commented Nov 12, 2019

traversaro commented Dec 4, 2019

lrapetti commented Dec 17, 2019

traversaro commented Oct 23, 2019 •

edited

Loading

traversaro commented Oct 23, 2019 •

edited

Loading

traversaro commented Oct 23, 2019 •

edited

Loading

traversaro commented Nov 7, 2019 •

edited

Loading

lrapetti commented Nov 12, 2019 •

edited

Loading

lrapetti commented Nov 12, 2019 •

edited

Loading