Add Xsens saveCurrentCalibration option #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrapetti
approved these changes
Jun 8, 2021
app/xml/XsensSuitWearableDevice.xml
Outdated
Comment on lines
30
to
32
| <!-- Flag to save .mvn calibration --> | ||
| <param name="saveCurrentCalibration">true</param> | ||
| <!-- Quantities to be extracted from the driver for each time sample --> |
There was a problem hiding this comment.
nitpick, this block seems to have a different indentation wrt the rest of the file
There was a problem hiding this comment.
Done in 171fb42
|
Just notice that also |
Done in 9065070 |
|
We can merge it, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option of
saveCurrentCalibrationto Xsens wearable deviceThe saved calibration file is with
.mvnfile extensionCC @lrapetti @claudia-lat @DanielePucci