Add Windows support in GitHub Actions #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is not complete (the disabled part are documented in the scripts with the reference to the relative issue) but not it runs fine, so I think we can merge it as it is and modify it as soon as the blocking issue get resolved. |
pattacini
approved these changes
Nov 15, 2019
diegoferigo
approved these changes
Nov 15, 2019
| @@ -19,7 +19,7 @@ jobs: | |||
| matrix: | |||
| build_type: [Debug, Release] | |||
| project_tags: [Stable, Unstable] | |||
| os: [ubuntu-latest, macOS-10.14] | |||
| os: [ubuntu-latest, macOS-10.14, windows-2019] | |||
There was a problem hiding this comment.
I didn't find this key in the official documentation. Where did you find it?
There was a problem hiding this comment.
Apparently both windows-2019 and macOS-10.14 disappeared from the documentation, but they used to be there and they are still working fine. See actions/runner-images#81 for a related issue for macOS .
There was a problem hiding this comment.
I see, thanks for the link!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.