Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 2025 Council Pack 3 #1197

Merged
merged 18 commits into from
Jan 29, 2025
Merged

fix: 2025 Council Pack 3 #1197

merged 18 commits into from
Jan 29, 2025

Conversation

m26dvd
Copy link
Contributor

@m26dvd m26dvd commented Jan 28, 2025

Fixing the following councils
fix: #1139 - Swale Borough Council
fix: #1192 - Midlothian Council
fix: #1179 - Newcastle City Council
fix: #1175 - Cardiff Council
fix: #1145
fix: #1127
fix: #890

Adding support for the following councils:
fix: #1180 - Boston Borough Council
fix: #1178 - Leicester City Council
fix: #1052 - East Staffordshire Borough Council
fix: #1083
fix: #1171 - East Lothian Council

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.93%. Comparing base (c662fed) to head (fd52b79).
Report is 21 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1197   +/-   ##
=======================================
  Coverage   71.93%   71.93%           
=======================================
  Files           9        9           
  Lines        1037     1037           
=======================================
  Hits          746      746           
  Misses        291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbrad
Copy link
Owner

robbrad commented Jan 28, 2025

@m26dvd : can you rebase off master to pullin the latest workflow files ?

@m26dvd m26dvd marked this pull request as ready for review January 28, 2025 23:46
@m26dvd m26dvd marked this pull request as draft January 28, 2025 23:51
@m26dvd
Copy link
Contributor Author

m26dvd commented Jan 28, 2025

@robbrad I'll keep this one open if you need to test any further

@robbrad
Copy link
Owner

robbrad commented Jan 29, 2025

@m26dvd any chance you could try again on this test - rebase make a small change and commit/push ?

@m26dvd
Copy link
Contributor Author

m26dvd commented Jan 29, 2025

@robbrad Still the pesky Deploy Reports issue!

@robbrad
Copy link
Owner

robbrad commented Jan 29, 2025

@robbrad Still the pesky Deploy Reports issue!

I just can't get past this issue

It works if I run it but from PRs from other forks it does not.

Also strange but the PAT says it's never been used when it has

@robbrad
Copy link
Owner

robbrad commented Jan 29, 2025

@m26dvd Can you please try again mate?

@m26dvd
Copy link
Contributor Author

m26dvd commented Jan 29, 2025

@robbrad Still erroring unfortunately

@geekball
Copy link
Contributor

@robbrad , I think it's permissions in the workflow (not an expert as use Azure DevOps at work), Did a bit of google digging and found:
(From: https://stackoverflow.com/questions/72851548/permission-denied-to-github-actionsbot)
permissions:
contents: read
pages: write # <-- Add this line

Looks like that pages: write should go around line 207/208 in the workflow since you're pushing to github pages?

@robbrad
Copy link
Owner

robbrad commented Jan 29, 2025

Last time please @m26dvd ! thank you 💯

@robbrad
Copy link
Owner

robbrad commented Jan 29, 2025

@robbrad , I think it's permissions in the workflow (not an expert as use Azure DevOps at work), Did a bit of google digging and found: (From: https://stackoverflow.com/questions/72851548/permission-denied-to-github-actionsbot) permissions: contents: read pages: write # <-- Add this line

Looks like that pages: write should go around line 207/208 in the workflow since you're pushing to github pages?

@m26dvd / @geekball

Yeh I tried that however its the commit to the branch that it does not like it looks like its inherent to GH not allowing the workflow to run from forks

Instead I have moved the reports from Allure (which is a shame cos they were nice to codecov)

I will update the documentation once I confirm it works

Here is an example of how they look - pretty nice cos on the PR you now get feedback on the failed test

image

image

image

image

@m26dvd m26dvd changed the title 2025 Council Pack 3 fix: 2025 Council Pack 3 Jan 29, 2025
@m26dvd m26dvd marked this pull request as ready for review January 29, 2025 23:32
@robbrad robbrad merged commit 114adb5 into robbrad:master Jan 29, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment