Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swale URL not fixed in December 2024 commit #1139

Closed
4 tasks done
dolce08 opened this issue Jan 6, 2025 · 2 comments · Fixed by #1197
Closed
4 tasks done

Swale URL not fixed in December 2024 commit #1139

dolce08 opened this issue Jan 6, 2025 · 2 comments · Fixed by #1197
Labels
bug Something isn't working

Comments

@dolce08
Copy link

dolce08 commented Jan 6, 2025

Name of Council

Swale Borough Council

Issue Information

Following from issue #1080 not sure if the fix is properly implemented in 0.126.0. It still defaults to the old URL. Changing the URL does not fix the issue. Tried completely removing and redownloading but no luck. It just gives raw JSON as a sensor.

Screenshot 2025-01-04 at 19 45 57 Screenshot 2025-01-04 at 20 10 56

Verification

  • I searched for similar issues at https://github.com/robbrad/UKBinCollectionData/issues?q=is:issue and found no duplicates
  • I have checked my address/postcode/UPRN works on the council's website
  • I have provided a detailed explanation of the issue as well as steps to replicate the issue
  • I understand that this project is run by volunteer contributors therefore completion of this issue cannot be guaranteed
@dolce08 dolce08 added the bug Something isn't working label Jan 6, 2025
@m26dvd
Copy link
Contributor

m26dvd commented Jan 16, 2025

The Swale Borough Council scraper code is configured to use https://swale.gov.uk/bins-littering-and-the-environment/bins/check-your-bin-day on the back end so it doesn't matter what you enter in the URL field of the configuration

Have you configured the postcode and house number fields correctly and also pointed the service at a Selenium server?

@dolce08
Copy link
Author

dolce08 commented Jan 16, 2025

Selenium is working.

I think the issue is the scraper doesn't detect a year so it is defaulting to 1900. The day dates are correct.
2025-01-16 09:19:33.089 DEBUG (MainThread) [custom_components.uk_bin_collection] [UKBinCollection] Parsed data: {'bins': [{'type': 'blue bin', 'collectionDate': '22/01/1900'}, {'type': 'food waste', 'collectionDate': '22/01/1900'}, {'type': 'green bin', 'collectionDate': '29/01/1900'}, {'type': 'food waste', 'collectionDate': '29/01/1900'}]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants