Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more consistency to rnp_op_verify_st/rnp_op_generate_st constructors. #2310

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Jan 29, 2025

As per this review comment: #2309 (comment)

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (dc13a59) to head (ee1bce5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/crypto/ecdsa.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2310   +/-   ##
=======================================
  Coverage   85.17%   85.17%           
=======================================
  Files         118      118           
  Lines       22793    22795    +2     
=======================================
+ Hits        19414    19416    +2     
  Misses       3379     3379           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-add-some-consistency branch from d359e0f to ee1bce5 Compare February 13, 2025 09:28
@ni4 ni4 requested a review from maxirmx February 13, 2025 11:28
@ni4 ni4 marked this pull request as ready for review February 13, 2025 11:28
@maxirmx maxirmx merged commit 6961056 into main Feb 14, 2025
123 checks passed
@maxirmx maxirmx deleted the ni4-add-some-consistency branch February 14, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants