Refactor encrypted_add_password(). #2309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ni4
commented
Jan 24, 2025
- for better code quality
- closer to c++ style
- workaround GnuPG multiple SKESKs handling, causing random CI failures for us.
…rs where applicable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
==========================================
+ Coverage 85.14% 85.17% +0.02%
==========================================
Files 118 118
Lines 22780 22793 +13
==========================================
+ Hits 19397 19413 +16
+ Misses 3383 3380 -3 ☔ View full report in Codecov by Sentry. |
2e29c5b to
5b04f48
Compare
5b04f48 to
9533758
Compare
desvxx
reviewed
Jan 29, 2025
| @@ -3340,11 +3301,8 @@ try { | |||
| return RNP_ERROR_NULL_POINTER; | |||
| } | |||
|
|
|||
| *op = new rnp_op_verify_st(); | |||
| rnp_ctx_init_ffi((*op)->rnpctx, ffi); | |||
| *op = new rnp_op_verify_st(ffi, signature); | |||
| (*op)->rnpctx.detached = true; | |||
There was a problem hiding this comment.
maybe it will be more consistent to add these params to constructor as well?
There was a problem hiding this comment.
Agree, thanks. Will address via another PR as this one is already merged.
desvxx
approved these changes
Jan 29, 2025
|
Merging with two approvals. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.