Monorepo with Lerna #1501
Monorepo with Lerna #1501
Conversation
using @rjsf-jasonritchie org and travis to get things fully working before creating PR
|
Hey, will take a look at this soon, but thanks for going ahead and doing this! |
* fix: update arrays correctly when changing index * fix: Update anyOf schema to correctly update items in an array * fix: update schema to re-render when idschema changes
* Inject defaults in arrays
When using dependencies in array items, defaults are now injected.
This adjusts injecting arrays into the form data from defaults to be
in line with the previous behaviour. So the defaults are injected when
there is either no value defined in the form data or when an array is
already set in the form data, injects only into existing entries.
This makes sure that we don't change any existing behaviour by creating
array entries where we did not create them before.
For example for following schema:
{
"type": "array",
"minItems": 2,
"items": {
"title": "asd",
"type": "object",
"properties": {
"item": {
"type": "string",
"default": "foo"
}
}
}
}
and following form data:
[{}]
The result will be (note how it did not full up the array to min items)
[{ "item": "foo" }]
* Remove redundant comment
* Add documentation and example
* Merge arrays defined in parent schema by overwriting same level arrays
* fix typo
* fix typos
* wording changes
Co-Authored-By: Dominik del Bondio <dominik.del.bondio@bitextender.com>
There was a problem hiding this comment.
I think it would be best to create a separate directory for playground (at the same level as packages) because we would want to have a single playground that showcases many themes. This would end up merging the playgrounds for core and material-ui eventually, though you could start with just using the core playground for now.
packages/core/.gitignore
Outdated
| @@ -0,0 +1,131 @@ | |||
| # Created by https://www.gitignore.io/api/osx,node,linux,windows | |||
There was a problem hiding this comment.
Why create separate gitignores for each package (as opposed to having a single gitignore at the root of the repo)?
There was a problem hiding this comment.
cleaned up the redundant gitignore files
* Fix rjsf-team#1431 - ie11 not able to submit * Fix code formatting * Add react-app-polyfill/ie11 for playground
|
I think there's a clear path of improvements we should pursue after we get this merged. There's good reason to merge this before it's "perfect" because integrating upstream changes when the paths of most files has changed has some friction and can leave confusing commit history. I'll add "themes in playground" to the "future improvements" list in the initial request. What do you think about the "Tasks before finalizing PR" list as it stands? |
|
Thanks! Good point about merging this as soon as possible. I ended up moving the playground folder back to |
Reasons for making this change
Use Lerna to maintain core and themes as a monorepo. This should streamline creation of new themes and maintenance of existing theme(s).
Status
I've published the packages to a temporary npm org using 'lerna publish'. I've also verified travis pipeline runs.
https://travis-ci.org/JasonRitchie/react-jsonschema-form/builds/607277676
https://www.npmjs.com/~jasonritchie
Tasks before finalizing PR
Future opportunities for improvement