Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update schema to re-render when idschema changes #1493

Merged

Conversation

SuriGill
Copy link
Contributor

@SuriGill SuriGill commented Oct 22, 2019

Reasons for making this change

Causing empty items to move up or down in an array of anyOf object fields will cause only the idSchema to change as the formData is just empty objects. As a result, the current implementation will not re-render the items and changing an input inside one of the anyOf object fields will update the wrong target. I've included a change to update the schema when idSchema changes as well.

If this is related to existing tickets, include links to them as well.
fixes second issue in #1486

  • I'm updating documentation
  • I'm adding or updating code
    • I've added and/or updated tests
    • I've updated docs if needed
  • I'm adding a new feature
    • I've updated the playground with an example use of the feature

@epicfaace
Copy link
Member

Good catch! Thanks

@epicfaace epicfaace merged commit 70c3a03 into rjsf-team:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants