ci: Use setup-sqlc@v4 action #82
Conversation
|
@andrewmbenton Thanks! Would you mind doing a no-op |
|
@brandur I think we might need to approve this first for a first-time contributor before the actions will run |
|
@bgentry So I have this feature on for other repos too, but usually there's an "approve CI run" button you can press. I'm not sure if I'm blind or there's a bug somewhere, but I'm not seeing it anywhere in my UI. Do you see it? |
|
I've been looking everywhere to find a setting that will make that button show up, afaict all the settings look correct but I don't see any way to approve the workflow per the docs 😖 |
|
WTH. I think it might be a bug ... I've seen the button hundreds of times before. It's just not here right now. |
|
@brandur I think we might need the |
|
@bgentry Doh. Okay NM, I guess that's it. Good idea to actually RTFM. |
|
Thank you @andrewmbenton 🙏 |
Happy to help work out the configuration kinks early on. |
A small clean up in `ci.yml` to remove the `BIN_PATH` variable, which was previously used for sqlc before #82 moved that to a GitHub Action. It's not a particular problem that `BIN_PATH` is there, but the comment above it that it's added to `PATH` is no longer true, so probably best to remove it for accuracy's sake.
A small clean up in `ci.yml` to remove the `BIN_PATH` variable, which was previously used for sqlc before #82 moved that to a GitHub Action. It's not a particular problem that `BIN_PATH` is there, but the comment above it that it's added to `PATH` is no longer true, so probably best to remove it for accuracy's sake.
Just noticed that your sqlc workflow would be simpler with the setup-sqlc GitHub action.