Small ci.yml clean up to remove BIN_PATH
#180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small clean up in `ci.yml` to remove the `BIN_PATH` variable, which was previously used for sqlc before #82 moved that to a GitHub Action. It's not a particular problem that `BIN_PATH` is there, but the comment above it that it's added to `PATH` is no longer true, so probably best to remove it for accuracy's sake.
bgentry
approved these changes
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small clean up in
ci.ymlto remove theBIN_PATHvariable, whichwas previously used for sqlc before #82 moved that to a GitHub Action.
It's not a particular problem that
BIN_PATHis there, but the commentabove it that it's added to
PATHis no longer true, so probably bestto remove it for accuracy's sake.