Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted incorrect statement about ASR needed for all M and S mode CSRs #462

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

francislaus
Copy link
Contributor

The mtidc and stidc registers do not require ASR permission when read. This makes the deleted statements wrong.

@francislaus
Copy link
Contributor Author

Thinking about it, it might be better to amend the statements as follows:

<<pcc>> must grant <<asr_perm>> to access M-mode CSRs regardless of the RISC-V privilege mode with exception of the <<mtidc>> not requiring <<pcc>> to grant <<asr_perm>> for read accesses.

@francislaus
Copy link
Contributor Author

Also, this statement is not true any longer for unprivileged CSRs anymore:

Unlike machine and supervisor level CSRs, {cheri_base_ext_name} does not require

I propose: Only writing the <<utidc>> register requires <<pcc> to grant <<asr_perm>>, all other unprivileged CSRs do not require <<pcc>> to grant <<asr_perm>> to access unprivileged CSRs.
`

@tariqkurd-repo
Copy link
Collaborator

I think the definiton of ASR-perm is correct - so maybe the PR is ok as it is?

francislaus and others added 2 commits December 11, 2024 13:44
…n.adoc

Co-authored-by: Tariq Kurd <tariqandlaura@gmail.com>
Signed-off-by: Franz Fuchs <francislaus@users.noreply.github.com>
Co-authored-by: Tariq Kurd <tariqandlaura@gmail.com>
Signed-off-by: Franz Fuchs <francislaus@users.noreply.github.com>
@tariqkurd-repo tariqkurd-repo merged commit ca513a7 into riscv:main Dec 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants