specification: Clear all ATC cache when unbinding a TDI #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
approved these changes
May 14, 2024
sameo
commented
May 14, 2024
src/07-theory_operations.adoc
Outdated
| 8. The TSM removes all C-IOMMU, TVM G-stage mappings and the MMIO gpa -> hpa | ||
| mapping for the interface. | ||
| 8. The TSM removes all C-IOMMU mappings and all cached C-IOMMU ATC mappings, the | ||
| TVM G-stage mappings and the MMIO gpa -> hpa mappings for the interface. |
There was a problem hiding this comment.
Note: Add a glossary entry for ATC
jyao1
reviewed
May 14, 2024
src/07-theory_operations.adoc
Outdated
| @@ -923,8 +923,8 @@ Unbinding an interface from a TVM goes through the following steps: | |||
| belongs to a bound interface, or if it does not belong to the MMIO gpa -> hpa | |||
| mapping the TSM initially created for the interface at | |||
| xref:binding-flow[TDI binding time]. | |||
| 8. The TSM removes all C-IOMMU, TVM G-stage mappings and the MMIO gpa -> hpa | |||
| mapping for the interface. | |||
| 8. The TSM removes all C-IOMMU mappings and all cached C-IOMMU ATC mappings, the | |||
There was a problem hiding this comment.
Maybe add full name for ATC?
There was a problem hiding this comment.
Done as well, thanks.
0926b67 to
99e5f52
Compare
Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
99e5f52 to
e1ba3a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.