specification: Define the interface unbinding flows #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef13c22 to
6f3d217
Compare
jyao1
reviewed
Apr 30, 2024
| As the platform resources owner, only the host supervisor domain manager may | ||
| decide to unbind an interface from a TVM. At any moment, it can choose to do so | ||
| through the `sbi_covh_unbind_interface()` `COVH` ABI. The targeted TSM services | ||
| the request by moving the TDI from the TDISP `CONFIG_LOCKED` or `RUN` state back |
There was a problem hiding this comment.
I think it handles ERROR state as well.
jyao1
reviewed
Apr 30, 2024
| participant TVM | ||
| participant IOMMU | ||
|
|
||
| note over TDI: CONFIG_LOCKED or RUN |
jyao1
reviewed
Apr 30, 2024
| VMM ->> TSM: [COVH] sbi_covh_unbind_interface() | ||
| TSM ->> TSM: Generate TDISP STOP_INTERFACE_REQUEST | ||
| TSM ->> VMM: [COVH] spdm_req(STOP_INTERFACE_REQUEST) | ||
| VMM ->> DSM: [DOE] SPDM_STOP_INTERFACE_REQUEST |
There was a problem hiding this comment.
I feel the name SPDM_STOP_INTERFACE_REQUEST is confusing.
It is really a TDIPS protocol in SPDM session. But it is not SPDM protocol.
Maybe just call it spdm_req(STOP_INTERFACE_REQUEST)
There was a problem hiding this comment.
Makes sense, this is fixed now.
jyao1
reviewed
Apr 30, 2024
| TDI ->> TDI: Abort or complete all pending DMA requests | ||
| TDI ->> TDI: Scrub all TDI secrets and confidential data | ||
| note over TDI: CONFIG_UNLOCKED | ||
| DSM ->> VMM: [DOE] SPDM_STOP_INTERFACE_RESPONSE |
Fixes riscv-non-isa#57 Signed-off-by: Samuel Ortiz <sameo@rivosinc.com>
jyao1
approved these changes
May 7, 2024
rsahita
reviewed
May 7, 2024
| mapping the TSM initially created for the interface at | ||
| xref:binding-flow[TDI binding time]. | ||
| 8. The TSM removes all C-IOMMU, TVM G-stage mappings and the MMIO gpa -> hpa | ||
| mapping for the interface. |
There was a problem hiding this comment.
sorry for the late comment - does step 8 include removing all cached C-IOMMU ATC mappings for the interface being unbound?
There was a problem hiding this comment.
Good call. We're being explicit about it in #121
rsahita
reviewed
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57