Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Multiple Metrics in Leaderboards #6816

Open
wants to merge 212 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
212 commits
Select commit Hold shift + click to select a range
e8c38ee
initial multi metrics menu
lovincyrus Feb 20, 2025
ba416e9
search in metrics dropdown
lovincyrus Feb 20, 2025
fc8ad17
metrics dropdown menu
lovincyrus Feb 20, 2025
a963a1c
selected measure names in dashboard state
lovincyrus Feb 21, 2025
9e7a9d6
show correct measures display text based on count
lovincyrus Feb 21, 2025
33eb2ec
leaderboard measure names
lovincyrus Feb 21, 2025
b8a5c5c
default value for leaderboard measure names
lovincyrus Feb 21, 2025
f0a69c6
clean up leaderboardMeasureName references
lovincyrus Feb 21, 2025
7cab8bb
remaining leaderboardMeasureName references
lovincyrus Feb 21, 2025
73cb33a
set leaderboard name to names
lovincyrus Feb 21, 2025
bbdc8f7
rename prop first measure in dropdown
lovincyrus Feb 21, 2025
d059cab
wip
lovincyrus Feb 21, 2025
263603a
multiple sorts in aggregation query wip
lovincyrus Feb 24, 2025
c91274c
add active measure names to measures
lovincyrus Feb 24, 2025
57576d1
toggle leaderboard measure names
lovincyrus Feb 25, 2025
0c01bae
centralize toggle action to state manager
lovincyrus Feb 25, 2025
1ad1e0e
support leaderboard measure names in DimensionDisplay
lovincyrus Feb 25, 2025
4f6c4c4
fix toggle leaderboard
lovincyrus Feb 25, 2025
ae9bb9b
refactor set leaderboard measure name to using toggle
lovincyrus Feb 25, 2025
800ba33
initial context column dropdown
lovincyrus Feb 25, 2025
c4d4467
only show context menu when comparison is enabled
lovincyrus Feb 25, 2025
d7d01c0
use comparison time range
lovincyrus Feb 25, 2025
86f82b5
construct options context col
lovincyrus Feb 25, 2025
d57beb2
icons
lovincyrus Feb 25, 2025
36f7cdc
polish icon
lovincyrus Feb 25, 2025
65700ea
context column selectors clean up
lovincyrus Feb 26, 2025
3964151
one more
lovincyrus Feb 26, 2025
94a8307
add leaderboard context column filters state
lovincyrus Feb 26, 2025
2532eb0
clean up
lovincyrus Feb 26, 2025
dbe71bc
context column filters
lovincyrus Feb 26, 2025
fc61736
fix context col widths
lovincyrus Feb 26, 2025
9313724
summable metrics layout tweak in menu item
lovincyrus Feb 26, 2025
061d10f
context col selector in dimension display
lovincyrus Feb 26, 2025
03ed3ec
context col filters with comparison properties in dimension table
lovincyrus Feb 26, 2025
e4e6d68
clean up
lovincyrus Feb 27, 2025
f503c41
use existing delta, percentage of total icons
lovincyrus Feb 27, 2025
7b3d862
revert to getSort, remove getMultipleSort
lovincyrus Feb 27, 2025
5d867a5
clean up
lovincyrus Feb 27, 2025
6427bc2
add perc of total to explore, even when in not expanded leaderboard
lovincyrus Feb 27, 2025
f41b834
fix column count based on context cols
lovincyrus Feb 27, 2025
400b346
adjust expand table spacing
lovincyrus Feb 27, 2025
9f7a424
tweat enableSorting, hide sort copy in tooltip for non-highlighted cols
lovincyrus Feb 27, 2025
f8b4e97
Revert "tweat enableSorting, hide sort copy in tooltip for non-highli…
lovincyrus Feb 27, 2025
74128ac
support multiple measures with comparisons in dim table utils
lovincyrus Feb 28, 2025
a8c73fe
toggle all measures in context column selector
lovincyrus Feb 28, 2025
40db401
fix show for all measures style
lovincyrus Feb 28, 2025
20ccc09
mise en place for grouped cols when multiple active measures
lovincyrus Feb 28, 2025
3f73fe2
multiple measure in not expanded leaderboard display, grid tweaks to col
lovincyrus Feb 28, 2025
dc4d857
only show sorting to the first measure in dimension view
lovincyrus Mar 1, 2025
300d727
scrollable
lovincyrus Mar 1, 2025
85dbb60
style tweaks in header, cell, row
lovincyrus Mar 3, 2025
5c74c39
leaderboard width default tweak, wip
lovincyrus Mar 3, 2025
69508bc
sort measure
lovincyrus Mar 4, 2025
82b58a7
clean up
lovincyrus Mar 4, 2025
c0d3fc7
improve arrow icon layout when toggling
lovincyrus Mar 4, 2025
4d602b3
sticky cols
lovincyrus Mar 4, 2025
14cfae5
remove unused highlight col
lovincyrus Mar 4, 2025
6851d5b
fix lints in dimension display
lovincyrus Mar 4, 2025
09143a2
lint
lovincyrus Mar 4, 2025
ff1315f
lint
lovincyrus Mar 4, 2025
16641ae
lint
lovincyrus Mar 4, 2025
703a998
lint
lovincyrus Mar 4, 2025
11c7dc2
offline feedbacl
lovincyrus Mar 4, 2025
721ef0a
labels for col headers
lovincyrus Mar 4, 2025
e23108f
ability to set default column width in column store, ctx col width
lovincyrus Mar 4, 2025
e75d3c3
consistent delta col width
lovincyrus Mar 4, 2025
d8ad916
wip
lovincyrus Mar 4, 2025
2dfb07e
account for long leaderboard header
lovincyrus Mar 4, 2025
a328155
dimension table column width tweaks, wip
lovincyrus Mar 4, 2025
58035f5
use comparison col width on percent of total
lovincyrus Mar 4, 2025
f23a884
show context col dropdown regardless of comparison
lovincyrus Mar 4, 2025
7badac2
revert expand text spacing
lovincyrus Mar 4, 2025
e4a76f0
add contextMeasures to v1ExplorePreset
lovincyrus Mar 5, 2025
ae8d5f0
rename
lovincyrus Mar 5, 2025
3083529
sync active measures to contextMeasures to url parameter
lovincyrus Mar 5, 2025
c8608bc
testing
lovincyrus Mar 5, 2025
26cb55d
dedup measures in leaderboard
lovincyrus Mar 5, 2025
691ebcf
fix broken set default sort_by url param state
lovincyrus Mar 5, 2025
3774979
enable comparison when selecting context cols
lovincyrus Mar 5, 2025
a0ab0df
clean up
lovincyrus Mar 6, 2025
7439b05
reset
lovincyrus Mar 6, 2025
dd62b02
sorted measure name
lovincyrus Mar 6, 2025
7287a89
prep sorted for dimension cols using sorted measure name
lovincyrus Mar 6, 2025
75e4888
improve readability of toggleSort
lovincyrus Mar 6, 2025
e8bf3ee
Revert "improve readability of toggleSort"
lovincyrus Mar 6, 2025
c4894e4
reorg
lovincyrus Mar 6, 2025
45fe15b
revert
lovincyrus Mar 6, 2025
b13b1b3
leaderboard measure count
lovincyrus Mar 7, 2025
539843a
comment out gzip for dev
lovincyrus Mar 7, 2025
f4fd519
re-enable comparison time range for delta comparisons
lovincyrus Mar 7, 2025
c8fb13b
use top k measure count by visible measures
lovincyrus Mar 7, 2025
e92a187
clean up context measures
lovincyrus Mar 7, 2025
3f979b0
revert to leaderboard measure name for single selection
lovincyrus Mar 7, 2025
1f24523
Revert "revert to leaderboard measure name for single selection"
lovincyrus Mar 7, 2025
7dec962
leaderboard measure count url param
lovincyrus Mar 7, 2025
be9f4a8
revert toggleLeaderboardMeasureNames to setLeaderboardMeasureName
lovincyrus Mar 7, 2025
f99d5b6
revert leaderboard measure names changes, second attempt
lovincyrus Mar 7, 2025
95d1746
context columns tweaks
lovincyrus Mar 7, 2025
bfb46da
leaderboard context column url parameter, spacing to the left of seco…
lovincyrus Mar 7, 2025
225075d
wip
lovincyrus Mar 7, 2025
9442c8e
first column rename to dimension column width
lovincyrus Mar 8, 2025
260907d
one more
lovincyrus Mar 8, 2025
9bfb7db
final_final_final number selector design
lovincyrus Mar 8, 2025
285ac7b
context col selector in dimension detail
lovincyrus Mar 8, 2025
eb75ce3
clean slate
lovincyrus Mar 8, 2025
028fab7
fix edge case of sort by and ledaerboard measure count
lovincyrus Mar 8, 2025
0ee8875
hmm
lovincyrus Mar 8, 2025
743f0c4
default to 1 leaderboard measure count
lovincyrus Mar 8, 2025
0747a93
wip
lovincyrus Mar 9, 2025
e2387d5
persist leadeboard measure count and context columns in the url
lovincyrus Mar 10, 2025
a18e059
check for sortMeasure when showing sort icon in leaderboard header
lovincyrus Mar 10, 2025
f3079ea
support ctx cols in comparison properties
lovincyrus Mar 10, 2025
e5523d6
revert previous changes to show delta comparisons regardless of time …
lovincyrus Mar 10, 2025
4dab12a
track dimension show for all measures state, toggle
lovincyrus Mar 10, 2025
cf26aab
remove single contextColumn selector
lovincyrus Mar 10, 2025
08f2073
support show for all measures
lovincyrus Mar 10, 2025
c001f90
rename sortMeasure to sortByMeasure
lovincyrus Mar 10, 2025
a5fa4ac
can show for all measures only in expanded
lovincyrus Mar 10, 2025
ab714a9
fix consistency of valid percent of total
lovincyrus Mar 10, 2025
53a990c
comparison column width tweaks
lovincyrus Mar 10, 2025
55bd1d8
wip
lovincyrus Mar 10, 2025
39d5d77
revert offset in bg gradient leaderboard row, tweak
lovincyrus Mar 10, 2025
7143fe5
gracefully remove sort_by when there is no leaderboard_measure_count
lovincyrus Mar 11, 2025
afdcbfa
fix undefined leaderboard measure count in the url
lovincyrus Mar 11, 2025
9619668
revert visible measures param
lovincyrus Mar 11, 2025
c3085a8
revert sort by from explore url params
lovincyrus Mar 11, 2025
ffd36c6
clean up
lovincyrus Mar 11, 2025
f3be342
workaround for context cols and comparison off
lovincyrus Mar 11, 2025
1fa0acf
fix invalid url state variations
lovincyrus Mar 11, 2025
9187ba1
delayed loading rows
lovincyrus Mar 11, 2025
ae1fb0b
fixes
lovincyrus Mar 11, 2025
a7db49b
compress params
lovincyrus Mar 11, 2025
a35d511
feedback
lovincyrus Mar 11, 2025
7bdfd76
rename dimension show all measures
lovincyrus Mar 11, 2025
814c2c9
fix layout shift in leaderboard measure count selector
lovincyrus Mar 11, 2025
32e5878
one more
lovincyrus Mar 11, 2025
0b3bb47
nit
lovincyrus Mar 11, 2025
69f6d59
offline feedback
lovincyrus Mar 11, 2025
0bbafa6
show all measures in leaderboard
lovincyrus Mar 11, 2025
7318ee3
actual implementation of show all measures in leaderboard, tweak vali…
lovincyrus Mar 11, 2025
f26bc64
dimension col width, table width
lovincyrus Mar 11, 2025
df92d14
clean up
lovincyrus Mar 11, 2025
1015aa3
workaround
lovincyrus Mar 11, 2025
bbc6117
offset bg, default comparison col width
lovincyrus Mar 11, 2025
3d75c64
fix unit test
lovincyrus Mar 11, 2025
58f488e
do not hide % of total option, tooltip
lovincyrus Mar 12, 2025
8d872d3
improvement on should suppress for valid percent of total
lovincyrus Mar 12, 2025
1a904f2
show context columns even in sorted by dimension
lovincyrus Mar 12, 2025
8bd2e02
invalid url state variations
lovincyrus Mar 12, 2025
1d4ea4e
e2e
lovincyrus Mar 12, 2025
79dca6a
clean up context col dropdown
lovincyrus Mar 12, 2025
0093730
arrange order
lovincyrus Mar 12, 2025
9b8ee2e
e2e
lovincyrus Mar 12, 2025
1b71af7
clean up
lovincyrus Mar 13, 2025
2d1cd1a
e2e
lovincyrus Mar 13, 2025
06df5f3
reorder context columns in leaderboard and dimension detail
lovincyrus Mar 13, 2025
67ad74a
update tooltip copy
lovincyrus Mar 13, 2025
cccf661
workaround for sticky leaderboard
lovincyrus Mar 13, 2025
8e71295
style
lovincyrus Mar 13, 2025
681d39c
nix leaderboard_measure_count url param
lovincyrus Mar 14, 2025
56a44b6
nix leaderboard_context_columns url param
lovincyrus Mar 14, 2025
dfa158c
add feature flag
lovincyrus Mar 14, 2025
d3f2704
create LeaderboardActiveMeasureDropdown
lovincyrus Mar 14, 2025
eb34571
remove deprecated explore states
lovincyrus Mar 14, 2025
ea4dc9b
remove all leaderboardContextColumns
lovincyrus Mar 14, 2025
31dfb78
use visible measures for measure count max
lovincyrus Mar 14, 2025
9882f2d
revert leaderboard and dimension's default col and comparison widths
lovincyrus Mar 14, 2025
6d8b4c8
show all comparison measures when time comparison is on in leaderboard
lovincyrus Mar 14, 2025
9f9574d
remove dimensionShowAllMeasures
lovincyrus Mar 14, 2025
44f835c
revert e2e fix
lovincyrus Mar 14, 2025
d6df7cc
clean up
lovincyrus Mar 14, 2025
8d5b28b
gate leadeboard measure names
lovincyrus Mar 14, 2025
da0c3b3
lint
lovincyrus Mar 14, 2025
d1cd14b
revert invalid url test
lovincyrus Mar 14, 2025
ece8331
comparison col widths
lovincyrus Mar 17, 2025
03dc5dd
handle sort by case when measure isn't visible from the filtered meas…
lovincyrus Mar 17, 2025
eba6e32
fix bleeding cell in leaderboard row
lovincyrus Mar 17, 2025
9221c90
wip
lovincyrus Mar 17, 2025
ca2fc5f
wip
lovincyrus Mar 17, 2025
ef90994
clean up
lovincyrus Mar 17, 2025
798494f
fix color in varchar and formatted data type
lovincyrus Mar 18, 2025
f82e7d1
fix fallback sort
lovincyrus Mar 18, 2025
73860b8
update copy text based on visible measures count
lovincyrus Mar 18, 2025
b3aa768
use count
lovincyrus Mar 18, 2025
676425c
context cols in dimension when time comparison is on
lovincyrus Mar 18, 2025
2aeb33b
fix perc of total in dimension
lovincyrus Mar 18, 2025
7b4c248
offline feedback
lovincyrus Mar 18, 2025
b917bd7
hardcoded text gray to override ui-copy
lovincyrus Mar 18, 2025
29727db
lint
lovincyrus Mar 18, 2025
f19fb36
fix
lovincyrus Mar 18, 2025
4e29e00
context column width tweaks, compact cell
lovincyrus Mar 18, 2025
ae3f8cd
truncate delta abs cell in leadearboard
lovincyrus Mar 18, 2025
e508c32
same treatment in dimension table
lovincyrus Mar 18, 2025
70dc2dd
rebase fix
lovincyrus Mar 19, 2025
09b5ff3
rebase fix
lovincyrus Mar 19, 2025
ee75a87
lint
lovincyrus Mar 19, 2025
58055d7
undefined check
lovincyrus Mar 19, 2025
acb6472
title
lovincyrus Mar 19, 2025
0f4a1e8
negative for delta abs in dimension table
lovincyrus Mar 19, 2025
60889fb
title
lovincyrus Mar 19, 2025
aa3a3c8
offline sync
lovincyrus Mar 19, 2025
8201734
lint
lovincyrus Mar 19, 2025
25c7c88
test fix
lovincyrus Mar 19, 2025
bf5dacf
test fix for percent of total col
lovincyrus Mar 19, 2025
ddbb6fe
test fix
lovincyrus Mar 19, 2025
3542fbe
clean up
lovincyrus Mar 19, 2025
23d3a5f
remove deadcode
lovincyrus Mar 20, 2025
338840e
Revert "nix leaderboard_measure_count url param"
lovincyrus Mar 20, 2025
8e94893
leaderboard_measure_count
lovincyrus Mar 20, 2025
1223bd7
fix layout shifts
lovincyrus Mar 20, 2025
1c289a0
more data attributes, remove usage deltaColumn
lovincyrus Mar 20, 2025
c83648f
clean up
lovincyrus Mar 20, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint
lovincyrus committed Mar 19, 2025

Verified

This commit was signed with the committer’s verified signature.
lovincyrus Cyrus Goh
commit ee75a876a05bc614cd0d8de5b9aada55a80c4349
2 changes: 0 additions & 2 deletions web-common/src/features/canvas/AddComponentDropdown.svelte
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
<script lang="ts">
import * as DropdownMenu from "@rilldata/web-common/components/dropdown-menu";
import Tooltip from "@rilldata/web-common/components/tooltip/Tooltip.svelte";
import TooltipContent from "@rilldata/web-common/components/tooltip/TooltipContent.svelte";
import { chartMetadata } from "@rilldata/web-common/features/canvas/components/charts/util";
import { Plus, PlusCircle } from "lucide-svelte";
import type { ComponentType, SvelteComponent } from "svelte";