-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Multiple Metrics in Leaderboards #6816
base: main
Are you sure you want to change the base?
Conversation
e98e1c5
to
a6f0616
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, the code looks like it's on track! I played around with the branch and observed bugs and opportunity for UX polish, but I won't enumerate all those given the PR is in draft state and I assume you see them too. I'll just say that the most jarring IMO is the layout shift when toggling the leaderboard's sorted measure.
web-common/src/features/dashboards/stores/metrics-explorer-entity.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/url-state/convertURLToExplorePreset.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/url-state/convertURLToExplorePreset.ts
Outdated
Show resolved
Hide resolved
24d7df6
to
e508c32
Compare
This pull request introduces support for multiple metrics in leaderboards, enabling users to adjust the
leaderboard_measure_count
to control the number of visible measures. This featured is gated by feature flagleaderboardMeasureCount
Closes #6713
https://www.notion.so/rilldata/Multiple-Metrics-in-Leaderboards-19aba33c8f57802f98aeefe569a81b39
Checklist: