Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Multiple Metrics in Leaderboards #6816

Open
wants to merge 206 commits into
base: main
Choose a base branch
from
Open

Conversation

lovincyrus
Copy link
Contributor

@lovincyrus lovincyrus commented Mar 4, 2025

This pull request introduces support for multiple metrics in leaderboards, enabling users to adjust the leaderboard_measure_count to control the number of visible measures. This featured is gated by feature flag leaderboardMeasureCount

features:
  - leaderboardMeasureCount

Closes #6713

https://www.notion.so/rilldata/Multiple-Metrics-in-Leaderboards-19aba33c8f57802f98aeefe569a81b39

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@lovincyrus lovincyrus force-pushed the cyrus/multiple-metrics branch 2 times, most recently from e98e1c5 to a6f0616 Compare March 6, 2025 17:01
@ericpgreen2 ericpgreen2 requested a review from jkhwu March 11, 2025 12:32
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the code looks like it's on track! I played around with the branch and observed bugs and opportunity for UX polish, but I won't enumerate all those given the PR is in draft state and I assume you see them too. I'll just say that the most jarring IMO is the layout shift when toggling the leaderboard's sorted measure.

@lovincyrus lovincyrus force-pushed the cyrus/multiple-metrics branch from 24d7df6 to e508c32 Compare March 19, 2025 15:24
@lovincyrus lovincyrus marked this pull request as ready for review March 19, 2025 23:19
@lovincyrus lovincyrus requested a review from ericpgreen2 March 19, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leaderboards: Multiple Measures
2 participants