Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for registering in General #14

Merged
merged 6 commits into from
Oct 22, 2019
Merged

Prepare for registering in General #14

merged 6 commits into from
Oct 22, 2019

Conversation

amellnik
Copy link
Contributor

  • Enable codecov

@codecov-io
Copy link

codecov-io commented Oct 17, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d5ad60d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage          ?   94.24%           
=========================================
  Files             ?        8           
  Lines             ?      573           
  Branches          ?        0           
=========================================
  Hits              ?      540           
  Misses            ?       33           
  Partials          ?        0
Impacted Files Coverage Δ
src/ansys.jl 100% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5ad60d...a90ceac. Read the comment docs.

@amellnik amellnik changed the title [WIP] Prepare for registering in General Prepare for registering in General Oct 18, 2019
@amellnik
Copy link
Contributor Author

amellnik commented Oct 18, 2019 •
edited
Loading

I don't think there's actually much to do here unless we want to expand the docs -- this should be good to go.

Edit: We need some upper bounds, see here: JuliaRegistries/General#4510 (comment)

@amellnik amellnik changed the title Prepare for registering in General [WIP] Prepare for registering in General Oct 18, 2019
@ajkeller34
Copy link
Contributor

Closing and reopening to retrigger CI—one of the workers timed out before even starting the tests.

@ajkeller34 ajkeller34 closed this Oct 18, 2019
@ajkeller34 ajkeller34 reopened this Oct 18, 2019
@ajkeller34 ajkeller34 force-pushed the get-ready-for-general branch from 0e14107 to f095b00 Compare October 21, 2019 23:38
@ajkeller34 ajkeller34 force-pushed the get-ready-for-general branch from f095b00 to a90ceac Compare October 21, 2019 23:52
@ajkeller34 ajkeller34 changed the title [WIP] Prepare for registering in General Prepare for registering in General Oct 22, 2019
@ajkeller34 ajkeller34 requested a review from dangirsh October 22, 2019 00:09
dangirsh
dangirsh reviewed Oct 22, 2019
View reviewed changes
src/ansys.jl Show resolved Hide resolved
@ajkeller34 ajkeller34 merged commit 87cc562 into master Oct 22, 2019
@ajkeller34 ajkeller34 deleted the get-ready-for-general branch October 22, 2019 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkeller34 ajkeller34 ajkeller34 left review comments

@dangirsh dangirsh dangirsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amellnik @codecov-io @ajkeller34 @dangirsh