Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: AdmittanceModels v0.1.0 #4510

Closed

Conversation

JuliaRegistrator
Copy link
Contributor

UUID: 5eda1363-42a2-4d75-bc45-7e2a4a7b92b2
Repo: https://github.com/rigetti/AdmittanceModels.jl.git
Tree: 30fd19c95db0b6f60150ef197c7095bf39a06f77

Registrator tree SHA: f50e50c1d2a1b9694b1d5749fdb25fef2ca4c291
@ghost
Copy link

ghost commented Oct 18, 2019

Your new package pull request does not meet all of the guidelines for automatic merging.

Specifically, your pull request does not meet the following guidelines:

  • The following dependencies do not have a compat entry that has an upper bound: Combinatorics, julia, IterativeSolvers, UniqueVectors, MatrixNetworks

It is important to note that if your pull request does not meet the guidelines for automatic merging, this does not mean that your pull request will never be merged. It just means that your pull request will require manual review by a human.

These guidelines are intended not as requirements for packages but as very conservative guidelines, which, if your new package or new version of a package meets them, it may be automatically merged.


On a separate note, I see that you are registering a release with a version number of the form v0.X.Y.

Does your package have a stable public API? If so, then it's time for you to register version v1.0.0 of your package. (This is not a requirement. It's just a recommendation.)

If your package does not yet have a stable public API, then of course you are not yet ready to release version v1.0.0.


[noblock]

@amellnik
Copy link
Contributor

Please close this PR, we will make some changes and resubmit.

@fredrikekre fredrikekre deleted the registrator/admittancemodels/5eda1363/v0.1.0 branch October 28, 2019 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants