Refactor convoluted ViewportBlueprint logic
#8241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
ViewportBlueprint logic
Wumpf
reviewed
Nov 28, 2024
6 tasks
emilk
added a commit
that referenced
this pull request
Dec 2, 2024
* Fixed bug introduced in #8241 Before we would be left with empty containers.
emilk
added a commit
that referenced
this pull request
Dec 2, 2024
### What * Closes #3135 * Proceeded by #7602 * Proceeded by #7603 * Proceeded by #8241 * New issue: #8249 This PR implements Undo and Redo for any edit to the active blueprint. https://github.com/user-attachments/assets/05018729-f01e-42f4-a84f-b48dbf31b060 ### Implementation This implements undo/redo by editing the "time cursor" for the blueprint timeline. Undo moves it backwards, redo forwards. When doing an action, all redo history is erased from the store with a new `ChunkStore::drop_time_range` function. ### Known shortcomings * Undo doesn't work when the blueprint streams panel is open ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7546?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/7546?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/7546) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`. --------- Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
emilk
added a commit
that referenced
this pull request
Dec 2, 2024
* Fixed bug introduced in #8241 Before we would be left with empty containers.
emilk
added a commit
that referenced
this pull request
Dec 2, 2024
### Related * Fixed bug introduced in #8241 ### What Before we would be left with empty containers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related
What
This refactors
Viewport(now calledViewportUi) andViewportBlueprintto much simpler.ViewportUiTreeActionis now calledViewportCommandArc<Mutex<Vec<ViewportCommand>>>IncludedSpaceView