Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undo (and redo) in viewer #3135

Closed
roym899 opened this issue Aug 29, 2023 · 1 comment · Fixed by #7546
Closed

Undo (and redo) in viewer #3135

roym899 opened this issue Aug 29, 2023 · 1 comment · Fixed by #7546
Assignees
@emilk
Labels
blocked can't make progress right now 🟦 blueprint The data that defines our UI enhancement New feature or request ui concerns graphical user interface
Milestone
0.21 - Graph View...

Comments

@roym899
Copy link
Collaborator

roym899 commented Aug 29, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Sometimes I accidentally remove a space view, making it quite annoying to set it up again.
Similarly, sometimes I move a view around which destroys the tiling, but there's no way to undo without setting everything up from scratch.

Describe the solution you'd like
Undoing changes in the viewer (like removing and moving a view) with Ctrl+Z.

Redo would be nice to have as well, but not as important.

Related to #1132.
@roym899 roym899 added enhancement New feature or request 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 29, 2023
@nikolausWest nikolausWest added ui concerns graphical user interface 🟦 blueprint The data that defines our UI and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Aug 29, 2023
@emilk emilk added this to the Triage milestone Aug 5, 2024
@emilk emilk self-assigned this Sep 29, 2024
This was referenced Sep 29, 2024
Merged
Merged
Merged
teh-cmc pushed a commit that referenced this issue Oct 7, 2024
@emilk
ChunkStore: Protect specific time ranges during GC (#7603)
899b17b 
### What
* Part of #3135

This lets us protect a specific time range from being garbage-collected.

This will be used to implement undo, in order to protect the latest N
undo points (e.g. the latest 100, if we have max-undo=100).
teh-cmc added a commit that referenced this issue Oct 7, 2024
@emilk @teh-cmc
Add ChunkStore::drop_time_range (#7602)
8702f01 
### What
Adds `ChunkStore::drop_time_range` to drop all events within some time
range. Will be used to implement undo.

* Part of #3135
* Extracted from #7546

---------

Co-authored-by: Clement Rey <cr.rey.clement@gmail.com>
@emilk emilk modified the milestones: Triage, 0.20 - Maps, H.264 Nov 4, 2024
@emilk emilk mentioned this issue Nov 11, 2024
Closed
@emilk emilk added the blocked can't make progress right now label Nov 11, 2024
@emilk
Copy link
Member

emilk commented Nov 11, 2024

@emilk emilk mentioned this issue Nov 28, 2024
Merged
emilk added a commit that referenced this issue Nov 29, 2024
@emilk @Wumpf
Refactor convoluted ViewportBlueprint logic (#8241)
d6aebd6 
### Related
* Closes #8056
* Closes #4687
* Unblocks #3135 

### What

This refactors `Viewport` (now called `ViewportUi`) and
`ViewportBlueprint` to much simpler.

* The tree is no longer duplicated in `ViewportUi`
* `TreeAction` is now called `ViewportCommand`
* All mutation are now accumulated in an
`Arc<Mutex<Vec<ViewportCommand>>>`
* All mutations are applied at the end of the frame, and then stored to
blueprint store
* Removed unused component `IncludedSpaceView`
* A lot of cleanup

---------

Co-authored-by: Andreas Reich <andreas@rerun.io>
@emilk emilk closed this as completed in c9a1e42 Dec 2, 2024
@emilk emilk mentioned this issue Dec 6, 2024
Merged
emilk added a commit that referenced this issue Dec 9, 2024
@emilk
Support cmd-Y for redo (#8343)
b45cde6 
### Related
* #3135 

### What
You can now use cmd-Y to redo.

To implement that, I added the ability to have multiple keyboard
shortcuts per command, with the first one being the primary one.

Also adds `ctrl + ,` to open options on all platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
blocked can't make progress right now 🟦 blueprint The data that defines our UI enhancement New feature or request ui concerns graphical user interface
Projects
None yet
Milestone
0.21 - Graph View, Grid, Undo, Breadc...
Development

Successfully merging a pull request may close this issue.

Add Undo/Redo support in the viewer rerun-io/rerun
3 participants
@emilk @nikolausWest @roym899