Add support for preparing requests with base URL #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requests_toolbelt/sessions.py
Outdated
Comment on lines
73
to
78
| def request(self, method, url, *args, **kwargs): | ||
| """Send the request after generating the complete URL.""" | ||
| """Construct and send the request after generating the | ||
| complete URL. | ||
| """ | ||
| url = self.create_url(url) | ||
| return super(BaseUrlSession, self).request( | ||
| method, url, *args, **kwargs | ||
| ) |
There was a problem hiding this comment.
I believe we can get rid of this because super().request will go through prepare_request
We now override the `prepare_request` method of the Session to generate a complete URL from the session's base URL and a partial resource name. The request is then prepared with the complete URL. >>> from requests import Request >>> from requests_toolbelt import sessions >>> s = sessions.BaseUrlSession( ... base_url='https://example.com/resource/') >>> request = Request(method='GET', url='sub-resource/') >>> prepared_request = s.prepare_request(request) >>> r = s.send(prepared_request) >>> print(r.request.url) https://example.com/resource/sub-resource Closes requests#315.
beeab08 to
d2810a2
Compare
|
Thanks @mbBRCM ! : 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now override the
prepare_requestmethod of the Sessionto generate a complete URL from the session's base URL
and a partial resource name. The request is then prepared with
the complete URL.
Closes #315.