[requests_toolbelt.session] Prepared requests do not have the complete url

[mbBRCM]

This is working:

response = self.session.put(endpoint, headers=headers, data=string)

But this is not:

request = Request("PUT", endpoint, headers=headers, data=data)
prepped = session.prepare_request(request)
response = session.send(prepped)

Does requests_toolbelt have a way to prepare requests with the base url?

[sigmavirus24]

No, it doesn't

[mbBRCM]

@sigmavirus24 Is this something that could be added?

[sigmavirus24]

Yes, it is

[mbBRCM]

@sigmavirus24 Is it ok if I give it a try?

[sigmavirus24]

Absolutely!

[mbBRCM]

What do you think of this solution?

    def prepare_request(self, request, *args, **kwargs):
        """Prepare the request after generating the complete URL."""
        url = self.create_url(request.url)
        new_request = copy(request)
        new_request.url = url
        return super(BaseUrlSession, self).prepare_request(
            new_request, *args, **kwargs
        )

The copy is so we do not mutate the original Request object

[sigmavirus24]

I don't believe a copy is the right thing to do. Users can have file objects and such and pretending to copy will not preserve anything.

[mbBRCM]

Oh, ok - so is it fine to just substitute the complete url in the user's Request like this?

    def prepare_request(self, request, *args, **kwargs):
        """Prepare the request after generating the complete URL."""
        request.url = self.create_url(request.url)
        return super(BaseUrlSession, self).prepare_request(
            request, *args, **kwargs
        )

[sigmavirus24]

Yup. That's how I'd expect it to work because all too often those requests can't be reused