Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Expand shell variables in inputs #125

Closed
wants to merge 1 commit into from

Conversation

tbroadley
Copy link

Closes #123.

This PR fixes the issue in #123 by going back to constructing hub pull-request arguments in a string variable, rather than in an array. entrypoint.sh also goes back to running the hub pull-request command using sh -c.

I also considered using eval echo to evaluate $INPUT_PR_TITLE . But I'm given to understand that we should avoid eval in shell scripts. Although I think sh -c is equivalent, so maybe it isn't important to avoid using eval here.

@wei
Copy link
Member

wei commented Jan 21, 2023

Thank you @tbroadley we'll do some testing and get this merged! For now please use repo-sync/pull-request@v2.9

@tbroadley
Copy link
Author

Hey @wei , I wanted to check if you've had a chance to test this yet.

@JohnYoungers
Copy link

@wei bump: while the issue is superficial, it would be nice if we could get our PRs back to displaying accurate details

@heiskr heiskr requested a review from a team March 21, 2023 21:02
@tbroadley tbroadley closed this May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action stopped evaluating parameters as shell scripts
3 participants