Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Action stopped evaluating parameters as shell scripts #123

Closed
tbroadley opened this issue Jan 18, 2023 · 3 comments
Closed

Action stopped evaluating parameters as shell scripts #123

tbroadley opened this issue Jan 18, 2023 · 3 comments

Comments

@tbroadley
Copy link

tbroadley commented Jan 18, 2023

Hello! First off, thanks for the great repo. My company uses this repo to automatically create PRs. Here's a snippet from one of our GitHub Actions:

      - name: Create Pull Request
        uses: repo-sync/pull-request@v2
        with:
          pr_title: Update $(basename $(dirname $GITHUB_REF)) dependency to $(git rev-parse --short ${GITHUB_REF##*/})

Before about December 26, this would create PRs with names like "Update foo dependency to abc123". Now, this creates PRs with the literal name Update $(basename $(dirname $GITHUB_REF)) dependency to $(git rev-parse --short ${GITHUB_REF##*/}).

I suspect #117 caused this repo to stop interpreting parameters like pr_title as shell scripts.

@tbroadley
Copy link
Author

Let me know if you'd like me to put together a repro case.

@wei
Copy link
Member

wei commented Jan 19, 2023

As you stated, this is likely due to these lines in #117 https://github.com/repo-sync/pull-request/pull/117/files#diff-6f9d41d046756f0ddc2fcee0626bdb50100d12b88f293734eff742818e03efa2R159-R165

PR welcome!

@heiskr
Copy link
Contributor

heiskr commented Jun 12, 2023

Thank you for opening this issue. Per the updated README, we are in process of archiving this repository, and encourage using gh pr create directly in your workflows instead.

@heiskr heiskr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants