Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs PRs being opened as Regen docs pulumi@${PULUMI_VERSION} #8451

Closed
dixler opened this issue Jan 18, 2023 · 4 comments · Fixed by #8453
Closed

docs PRs being opened as Regen docs pulumi@${PULUMI_VERSION} #8451

dixler opened this issue Jan 18, 2023 · 4 comments · Fixed by #8453
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@dixler
Copy link
Contributor

dixler commented Jan 18, 2023

What happened?

Recently, regen docs dispatches are not correctly interpolating the PULUMI_VERSION
https://github.com/pulumi/docs/pulls?q=is%3Apr+is%3Aclosed+Regen+docs+pulumi+sort%3Acreated-desc+

Re-ran old CI jobs and they're also affected.

Probably some dependency being updated.

Steps to reproduce

Cut a release.

Expected Behavior

Opens docs PR like Regen docs pulumi@3.52.0

Actual Behavior

Opens docs PR like Regen docs pulumi@${PULUMI_VERSION}.

Output of pulumi about

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@dixler dixler added kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user labels Jan 18, 2023
@dixler dixler self-assigned this Jan 19, 2023
@dixler
Copy link
Contributor Author

dixler commented Jan 19, 2023

@dixler dixler transferred this issue from pulumi/pulumi Jan 19, 2023
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jan 19, 2023
@justinvp justinvp removed the resolution/fixed This issue was fixed label Jan 20, 2023
@justinvp justinvp reopened this Jan 20, 2023
@justinvp
Copy link
Member

@dixler, looks like this is still happening, e.g. #8455 which was opened after #8453

@dixler
Copy link
Contributor Author

dixler commented Jan 20, 2023

@justinvp I forgot to merge the PR before kicking of the release so it didn't use the new version.

@justinvp justinvp added the resolution/fixed This issue was fixed label Jan 20, 2023
@justinvp
Copy link
Member

ahh, ok. sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants